Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2504763003: [DevTools] Make all links have underline decoration. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make all links have underline decoration. Previously, external links only got underline on hover. Now they appear similary to resource links. Easy example is in remote devices drawer view. The motivation is that we don't know in advance whether the link is external or not (for example, resource may be loaded later) and so we shouldn't display them differently. This will also simplify the handling, as we can now remove the notion of resource vs. external link entirely. BUG=665661 Committed: https://crrev.com/d7ab52b4dfd0f24647699087d196a822b38d9f03 Cr-Commit-Position: refs/heads/master@{#432711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 2 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please. I discussed this with Chris, and he's fine with the change.
4 years, 1 month ago (2016-11-16 00:39:55 UTC) #2
lushnikov
lgtm
4 years, 1 month ago (2016-11-16 22:33:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504763003/1
4 years, 1 month ago (2016-11-16 22:34:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 02:39:09 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:50:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7ab52b4dfd0f24647699087d196a822b38d9f03
Cr-Commit-Position: refs/heads/master@{#432711}

Powered by Google App Engine
This is Rietveld 408576698