Change PPDCache to use a path inside the per-user profile.

Change PPDCache to use a path inside the per-user profile.

BUG=662755
Committed: https://crrev.com/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701
Cr-Commit-Position: refs/heads/master@{#432328}

[Carlson, 2016-11-15 21:15:36]

Description was changed from

==========
Change PPDCache to use a path inside the per-user profile.

BUG=662755
==========

to

==========
Change PPDCache to use a path inside the per-user profile.

BUG=662755
==========

[Carlson, 2016-11-15 21:15:37]

justincarlson@chromium.org changed reviewers:
+ skau@chromium.org, sky@chromium.org

[Carlson, 2016-11-15 21:16:26]

Scott:  Sorry about the churn in chrome_paths, after conversations with skau@
and vapier@ it looks like we need to do this in a per-profile directory.

[sky, 2016-11-15 22:18:37]

LGTM

https://codereview.chromium.org/2504763002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc (right):

https://codereview.chromium.org/2504763002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc:83:
base::FilePath ppd_cache_path = profile_->GetPath().Append("PPDCache");
I think you need FILE_PATH_LITERAL here, or AppendASCII, although maybe not as
this code is chromeos only.

[Carlson, 2016-11-15 22:25:12]

https://codereview.chromium.org/2504763002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc (right):

https://codereview.chromium.org/2504763002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc:83:
base::FilePath ppd_cache_path = profile_->GetPath().Append("PPDCache");
On 2016/11/15 22:18:37, sky wrote:
> I think you need FILE_PATH_LITERAL here, or AppendASCII, although maybe not as
> this code is chromeos only.

It is chromeos-specific, but no harm in being orthogonal, so done.

[Carlson, 2016-11-15 22:27:21]

The CQ bit was checked by justincarlson@chromium.org

[Carlson, 2016-11-15 22:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2504763002/#ps20001
(title: "Change PPDCache to use a path inside the per-user profile.")

[commit-bot: I haz the power, 2016-11-15 22:28:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:03:28]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Carlson, 2016-11-16 00:25:17]

The CQ bit was checked by justincarlson@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:26:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:52:57]

Description was changed from

==========
Change PPDCache to use a path inside the per-user profile.

BUG=662755
==========

to

==========
Change PPDCache to use a path inside the per-user profile.

BUG=662755
==========

[commit-bot: I haz the power, 2016-11-16 00:52:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 00:56:47]

Description was changed from

==========
Change PPDCache to use a path inside the per-user profile.

BUG=662755
==========

to

==========
Change PPDCache to use a path inside the per-user profile.

BUG=662755

Committed: https://crrev.com/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701
Cr-Commit-Position: refs/heads/master@{#432328}
==========

[commit-bot: I haz the power, 2016-11-16 00:56:48]

Patchset 2 (id:??) landed as
https://crrev.com/4f55b637f4b2f0dc5887b1e35b6ca7f7788c1701
Cr-Commit-Position: refs/heads/master@{#432328}