Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

Issue 2504753003: Bookmarks bar, tooltip should be seen only for folders with big names on macOS. (Closed)
Patch Set: Add unittest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
index 98e0acb74b961e19853be7680ff089ded27df5a5..6f411fa3e9b6b3709954508f6e3878805a07e685 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
@@ -449,7 +449,16 @@ - (BookmarkButton*)makeButtonForNode:(const BookmarkNode*)node
[button setAcceptsTrackIn:YES];
}
// Add a tooltip.
- [button setToolTip:[BookmarkMenuCocoaController tooltipForNode:node]];
+ if (node->is_folder()) {
+ NSString* title = base::SysUTF16ToNSString(node->GetTitle());
+ if ([title length] &&
+ [[button cell] cellSize].width >
+ bookmarks::kBookmarkMenuButtonMaximumWidth) {
+ [button setToolTip:[BookmarkMenuCocoaController tooltipForNode:node]];
+ }
+ } else {
+ [button setToolTip:[BookmarkMenuCocoaController tooltipForNode:node]];
+ }
} else {
[button setEnabled:NO];
[button setBordered:NO];
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698