Linux Aura: Fixes and improvements for cursor loader

ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <X11/Xatom.h>
 
@@ skipping 663 matching lines @@
       move_loop_->EndMoveLoop();
       return;
     }
     source_state_ = SOURCE_STATE_DROPPED;
     SendXdndDrop(source_window);
     return;
   }
 
   int cursor_type = ui::kCursorNull;
   switch (negotiated_operation_) {
-    case ui::DragDropTypes::DRAG_COPY:
-      cursor_type = ui::kCursorCopy;
+    case ui::DragDropTypes::DRAG_NONE:
+      cursor_type = ui::kCursorDndNone;
       break;
     case ui::DragDropTypes::DRAG_MOVE:
-      cursor_type = ui::kCursorMove;
+      cursor_type = ui::kCursorDndMove;
+      break;
+    case ui::DragDropTypes::DRAG_COPY:
+      cursor_type = ui::kCursorDndCopy;
+      break;
+    case ui::DragDropTypes::DRAG_LINK:
+      cursor_type = ui::kCursorDndLink;
       break;
     default:

[sadrul, 2016/11/17 16:17:03]

Remove the default:

[Tom (Use chromium acct), 2016/11/17 19:17:48]

Done.

-      cursor_type = ui::kCursorGrabbing;
-      break;
+      NOTREACHED();
   }
   move_loop_->UpdateCursor(cursor_manager_->GetInitializedCursor(cursor_type));
 
   // Note: event.data.[2,3] specify a rectangle. It is a request by the other
   // window to not send further XdndPosition messages while the cursor is
   // within it. However, it is considered advisory and (at least according to
   // the spec) the other side must handle further position messages within
   // it. GTK+ doesn't bother with this, so neither should we.
 
   if (next_position_message_.get()) {
@@ skipping 653 matching lines @@
     for (int x = 0; x < in_bitmap->width(); ++x) {
       if (SkColorGetA(in_row[x]) > kMinAlpha)
         return true;
     }
   }
 
   return false;
 }
 
 }  // namespace views