Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6207)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Issue 2504723003: Add Bookmarks.BookmarksInFolder histogram to bookmark manager. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
index 4914b68e8c26e355cd7f83febb7473aebaccd6e4..87be223908241ddbf0e71266d25e2616434a0eb4 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
@@ -149,6 +149,14 @@ cr.define('bmm', function() {
this.fixWidth_();
cr.dispatchSimpleEvent(this, 'load');
+ chrome.metricsPrivate.recordValue({
+ 'metricName': 'Bookmarks.BookmarksInFolder',
+ 'type': chrome.metricsPrivate.MetricTypeType.HISTOGRAM_LOG,
+ 'min': 0,
+ 'max': 200,
Dan Beam 2016/11/16 01:26:51 wait, why a max of 200?
Alexei Svitkine (slow) 2016/11/16 01:34:09 Suggest using equivalent of UMA_HISTOGRAM_COUNTS_1
calamity 2016/11/16 01:57:46 Done.
+ 'buckets': 10
+ }, this.dataModel.length);
+ console.log(this.dataModel.length);
Dan Beam 2016/11/16 01:26:51 nit: remove the log()
calamity 2016/11/16 01:57:46 Done.
},
/**
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698