Deflake ontimeout-event-override-after-failure by waiting longer for http

Deflake ontimeout-event-override-after-failure by waiting longer for http

This test flakes when the http server does not respond quick enough. I
suspect this happens on bots that are busy running other tests in
parallel. I was able to simulate this flakiness by lowering the XHR
timeout to 13ms.

This patch increases the XHR timeout from 100ms to 180ms which should
give more time for the test http server to respond. This has no effect
on overall test time because the pass condition is behind a 200ms timer.

After this patch lands, we need to monitor the following:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fxmlhttprequest%2Fontimeout-event-override-after-failure.html
If the flakiness disappears, the lines in TestExpectations should be removed.

BUG=464736, 665165
Committed: https://crrev.com/613135a62748f6d2f875f11b9096c368a3873714
Cr-Commit-Position: refs/heads/master@{#432409}

[pdr., 2016-11-15 21:01:16]

pdr@chromium.org changed reviewers:
+ tyoshino@chromium.org, yhirano@chromium.org

[pdr., 2016-11-15 21:01:42]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 21:02:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:21:11]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yhirano, 2016-11-16 02:13:28]

How about fixing the test here and removing the entries from TestExpectations
after we see the flakiness is fixed on the flakiness dashboard?

[pdr., 2016-11-16 04:46:28]

Description was changed from

==========
Deflake ontimeout-event-override-after-failure by waiting longer for http

This test flakes when the http server does not respond quick enough. I
suspect this happens on bots that are busy running other tests in
parallel. I was able to simulate this flakiness by lowering the XHR
timeout to 13ms.

This patch increases the XHR timeout from 100ms to 180ms which should
give more time for the test http server to respond. This has no effect
on overall test time because the pass condition is behind a 200ms timer.

BUG=464736,665165
==========

to

==========
Deflake ontimeout-event-override-after-failure by waiting longer for http

This test flakes when the http server does not respond quick enough. I
suspect this happens on bots that are busy running other tests in
parallel. I was able to simulate this flakiness by lowering the XHR
timeout to 13ms.

This patch increases the XHR timeout from 100ms to 180ms which should
give more time for the test http server to respond. This has no effect
on overall test time because the pass condition is behind a 200ms timer.

After this patch lands, we need to monitor the following:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
If the flakiness disappears, the lines in TestExpectations should be removed.

BUG=464736,665165
==========

[pdr., 2016-11-16 04:48:27]

On 2016/11/16 at 02:13:28, yhirano wrote:
> How about fixing the test here and removing the entries from TestExpectations
after we see the flakiness is fixed on the flakiness dashboard?

Good idea, patch and change description updated to reflect this.

[pdr., 2016-11-16 04:48:38]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 04:49:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-16 04:51:16]

lgtm, thanks.

[commit-bot: I haz the power, 2016-11-16 05:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 05:44:41]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-11-16 06:05:55]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-11-16 06:06:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-11-16 06:14:43]

lgtm

thank you

[commit-bot: I haz the power, 2016-11-16 06:46:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 06:48:49]

Description was changed from

==========
Deflake ontimeout-event-override-after-failure by waiting longer for http

This test flakes when the http server does not respond quick enough. I
suspect this happens on bots that are busy running other tests in
parallel. I was able to simulate this flakiness by lowering the XHR
timeout to 13ms.

This patch increases the XHR timeout from 100ms to 180ms which should
give more time for the test http server to respond. This has no effect
on overall test time because the pass condition is behind a 200ms timer.

After this patch lands, we need to monitor the following:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
If the flakiness disappears, the lines in TestExpectations should be removed.

BUG=464736,665165
==========

to

==========
Deflake ontimeout-event-override-after-failure by waiting longer for http

This test flakes when the http server does not respond quick enough. I
suspect this happens on bots that are busy running other tests in
parallel. I was able to simulate this flakiness by lowering the XHR
timeout to 13ms.

This patch increases the XHR timeout from 100ms to 180ms which should
give more time for the test http server to respond. This has no effect
on overall test time because the pass condition is behind a 200ms timer.

After this patch lands, we need to monitor the following:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
If the flakiness disappears, the lines in TestExpectations should be removed.

BUG=464736,665165

Committed: https://crrev.com/613135a62748f6d2f875f11b9096c368a3873714
Cr-Commit-Position: refs/heads/master@{#432409}
==========

[commit-bot: I haz the power, 2016-11-16 06:48:49]

Patchset 2 (id:??) landed as
https://crrev.com/613135a62748f6d2f875f11b9096c368a3873714
Cr-Commit-Position: refs/heads/master@{#432409}