Issue 250463004: Implement AES in different modes of operation, using AES-NI and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250463004: Implement AES in different modes of operation, using AES-NI and (Closed)

Created:
6 years, 8 months ago by wtc

Modified:
6 years, 8 months ago

Reviewers:
agl, Ryan Sleevi

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/nss

Visibility:
Public.

Implement AES in different modes of operation, using AES-NI and PCLMULQDQ-NI, for WIN32 and WIN64 platforms. Only the WIN32 assembly code is used right now. By Shay Gueron and Vlad Krasnov, Intel. Upstream NSS bug: https://bugzilla.mozilla.org/show_bug.cgi?id=979703 Original review URL: https://codereview.chromium.org/214183004 TBR=agl@chromium.org,rsleevi@chromium.org BUG=none

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5286 lines, -1 line)			Patch
M	README.chromium	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	nss.gyp	View	5 chunks	+25 lines, -0 lines	0 comments	Download
M	nss/lib/freebl/ctr.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	nss/lib/freebl/ctr.c	View	2 chunks	+62 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-aes.h	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-aes-x64-masm.asm	View	1 chunk	+971 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-aes-x86-masm.asm	View	1 chunk	+949 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-gcm.h	View	1 chunk	+83 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-gcm-wrap.c	View	1 chunk	+240 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-gcm-x64-masm.asm	View	1 chunk	+1301 lines, -0 lines	0 comments	Download
A	nss/lib/freebl/intel-gcm-x86-masm.asm	View	1 chunk	+1212 lines, -0 lines	0 comments	Download
M	nss/lib/freebl/rijndael.c	View	3 chunks	+12 lines, -1 line	0 comments	Download
A	patches/nss-intel-aes-windows.patch	View	1 chunk	+272 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

wtc

This CL is a clone of https://codereview.chromium.org/214183004. I had to change the base URL so ...

6 years, 8 months ago (2014-04-24 18:00:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/250463004/1

6 years, 8 months ago (2014-04-24 18:01:09 UTC) #3

Message was sent while issue was closed.

Change committed as 265958