Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2504613002: [parser,ast] Simplify MarkExpressionAsAssigned. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
Michael Starzinger, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser,ast] Simplify MarkExpressionAsAssigned. There's no need to return anything. Also add a DCHECK to make sure that we never mark a variable proxy as assigned that is already resolved (to avoid potential inconsistency with the variable's maybe_assigned status). R=littledan@chromium.org CC=mstarzinger@chromium.org BUG= Committed: https://crrev.com/48bbd1a7fefc601849ada069a09bbce4d57533eb Cr-Commit-Position: refs/heads/master@{#41072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/ast/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
neis
4 years, 1 month ago (2016-11-15 13:30:03 UTC) #1
Dan Ehrenberg
lgtm Nice cleanup
4 years, 1 month ago (2016-11-17 11:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504613002/1
4 years, 1 month ago (2016-11-17 11:43:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 12:09:32 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48bbd1a7fefc601849ada069a09bbce4d57533eb
Cr-Commit-Position: refs/heads/master@{#41072}

Powered by Google App Engine
This is Rietveld 408576698