Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2504603002: Revert of [wrapper-tracing] Enable flag per default (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [wrapper-tracing] Enable flag per default (patchset #2 id:20001 of https://codereview.chromium.org/2495173003/ ) Reason for revert: Revert for now, as v8 needs to roll with incremental flag enabled and we don't want the roll to get stuck. Original issue's description: > [wrapper-tracing] Enable flag per default > > Developer docs: > http://bit.ly/chrome-trace-wrappers > > BUG=chromium:468240 > > Committed: https://crrev.com/7db18648678acf332a4cb7c91b831dd231e26d62 > Cr-Commit-Position: refs/heads/master@{#431951} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468240 Committed: https://crrev.com/22b4f9c583ca8a3ef6aeae1903adb6445ebc9600 Cr-Commit-Position: refs/heads/master@{#432169}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
Michael Lippautz
Created Revert of [wrapper-tracing] Enable flag per default
4 years, 1 month ago (2016-11-15 13:25:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504603002/1
4 years, 1 month ago (2016-11-15 13:25:48 UTC) #3
Marcel Hlopko
lgtm
4 years, 1 month ago (2016-11-15 13:25:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 13:26:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22b4f9c583ca8a3ef6aeae1903adb6445ebc9600 Cr-Commit-Position: refs/heads/master@{#432169}
4 years, 1 month ago (2016-11-15 13:29:48 UTC) #7
haraken
4 years, 1 month ago (2016-11-15 16:07:44 UTC) #8
Message was sent while issue was closed.
On 2016/11/15 13:29:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/22b4f9c583ca8a3ef6aeae1903adb6445ebc9600
> Cr-Commit-Position: refs/heads/master@{#432169}

LGTM

Powered by Google App Engine
This is Rietveld 408576698