Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

Issue 2504573002: Don't call isURLAllowed() from layout. (Closed)
Patch Set: Fix everything Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/http/tests/misc/bubble-drag-events-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/security/local-iFrame-from-remote-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp » ('j') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
index 4284904bf9448c5037e27db2f0be1b3a065f0008..dc398ebdb80e06cb5b791829b86f9e4843c1e1d3 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
@@ -41,7 +41,7 @@ DEFINE_NODE_FACTORY(HTMLFrameElement)
bool HTMLFrameElement::layoutObjectIsNeeded(const ComputedStyle&) {
// For compatibility, frames render even when display: none is set.
- return isURLAllowed();
+ return contentFrame();
}
LayoutObject* HTMLFrameElement::createLayoutObject(const ComputedStyle&) {
« third_party/WebKit/LayoutTests/http/tests/misc/bubble-drag-events-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/security/local-iFrame-from-remote-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp » ('j') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698