third_party/WebKit/Source/core/html/HTMLFrameElement.cpp - Issue 2504573002: Don't call isURLAllowed() from layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

Issue 2504573002: Don't call isURLAllowed() from layout. (Closed)

Patch Set: Fix bad formatting that caused clang-format-diff to get confused. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

index 4284904bf9448c5037e27db2f0be1b3a065f0008..dc398ebdb80e06cb5b791829b86f9e4843c1e1d3 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

@@ -41,7 +41,7 @@ DEFINE_NODE_FACTORY(HTMLFrameElement)

bool HTMLFrameElement::layoutObjectIsNeeded(const ComputedStyle&) {

// For compatibility, frames render even when display: none is set.

- return isURLAllowed();

+ return contentFrame();

}

LayoutObject* HTMLFrameElement::createLayoutObject(const ComputedStyle&) {