Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

Issue 2504573002: Don't call isURLAllowed() from layout. (Closed)
Patch Set: Fix bad formatting that caused clang-format-diff to get confused. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 23 matching lines...) Expand all
34 bool canContainRangeEndPoint() const final { return false; } 34 bool canContainRangeEndPoint() const final { return false; }
35 35
36 // FrameOwner overrides: 36 // FrameOwner overrides:
37 ScrollbarMode scrollingMode() const override { return m_scrollingMode; } 37 ScrollbarMode scrollingMode() const override { return m_scrollingMode; }
38 int marginWidth() const override { return m_marginWidth; } 38 int marginWidth() const override { return m_marginWidth; }
39 int marginHeight() const override { return m_marginHeight; } 39 int marginHeight() const override { return m_marginHeight; }
40 40
41 protected: 41 protected:
42 HTMLFrameElementBase(const QualifiedName&, Document&); 42 HTMLFrameElementBase(const QualifiedName&, Document&);
43 43
44 bool isURLAllowed() const;
45
46 void parseAttribute(const QualifiedName&, 44 void parseAttribute(const QualifiedName&,
47 const AtomicString&, 45 const AtomicString&,
48 const AtomicString&) override; 46 const AtomicString&) override;
49 InsertionNotificationRequest insertedInto(ContainerNode*) override; 47 InsertionNotificationRequest insertedInto(ContainerNode*) override;
50 void didNotifySubtreeInsertionsToDocument() final; 48 void didNotifySubtreeInsertionsToDocument() final;
51 void attachLayoutTree(const AttachContext& = AttachContext()) override; 49 void attachLayoutTree(const AttachContext& = AttachContext()) override;
52 50
53 // FIXME: Remove this method once we have input routing in the browser 51 // FIXME: Remove this method once we have input routing in the browser
54 // process. See http://crbug.com/339659. 52 // process. See http://crbug.com/339659.
55 void defaultEventHandler(Event*) override; 53 void defaultEventHandler(Event*) override;
56 54
57 void setScrollingMode(ScrollbarMode); 55 void setScrollingMode(ScrollbarMode);
58 void setMarginWidth(int); 56 void setMarginWidth(int);
59 void setMarginHeight(int); 57 void setMarginHeight(int);
60 58
61 void frameOwnerPropertiesChanged(); 59 void frameOwnerPropertiesChanged();
62 60
63 private: 61 private:
64 bool supportsFocus() const final; 62 bool supportsFocus() const final;
65 void setFocused(bool) final; 63 void setFocused(bool) final;
66 64
67 bool isURLAttribute(const Attribute&) const final; 65 bool isURLAttribute(const Attribute&) const final;
68 bool hasLegalLinkAttribute(const QualifiedName&) const final; 66 bool hasLegalLinkAttribute(const QualifiedName&) const final;
69 bool isHTMLContentAttribute(const Attribute&) const final; 67 bool isHTMLContentAttribute(const Attribute&) const final;
70 68
71 bool areAuthorShadowsAllowed() const final { return false; } 69 bool areAuthorShadowsAllowed() const final { return false; }
72 70
73 void setLocation(const String&); 71 void setLocation(const String&);
74 void setNameAndOpenURL(); 72 void setNameAndOpenURL();
73 bool isURLAllowed() const;
75 void openURL(bool replaceCurrentItem = true); 74 void openURL(bool replaceCurrentItem = true);
76 75
77 ScrollbarMode m_scrollingMode; 76 ScrollbarMode m_scrollingMode;
78 int m_marginWidth; 77 int m_marginWidth;
79 int m_marginHeight; 78 int m_marginHeight;
80 79
81 AtomicString m_URL; 80 AtomicString m_URL;
82 AtomicString m_frameName; 81 AtomicString m_frameName;
83 }; 82 };
84 83
85 inline bool isHTMLFrameElementBase(const HTMLElement& element) { 84 inline bool isHTMLFrameElementBase(const HTMLElement& element) {
86 return isHTMLFrameElement(element) || isHTMLIFrameElement(element); 85 return isHTMLFrameElement(element) || isHTMLIFrameElement(element);
87 } 86 }
88 87
89 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase); 88 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase);
90 89
91 } // namespace blink 90 } // namespace blink
92 91
93 #endif // HTMLFrameElementBase_h 92 #endif // HTMLFrameElementBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698