Don't call isURLAllowed() from layout.

third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "core/html/HTMLFrameOwnerElement.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/PaintInvalidationState.h"
 #include "core/paint/PaintLayer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class VisualRectMappingTest : public RenderingTest {
  public:
@@ skipping 98 matching lines @@
                                          layoutView(), layoutView());
 
   rect = LayoutRect(0, 60, 80, 0);
   EXPECT_TRUE(
       leaf->mapToVisualRectInAncestorSpace(container, rect, EdgeInclusive));
   rect.move(-container->scrolledContentOffset());
   EXPECT_EQ(rect, LayoutRect(0, 10, 80, 0));
 }
 
 TEST_F(VisualRectMappingTest, LayoutView) {
+  setChildFrameHTML(
+      "<style>body { margin: 0; }</style><span><img style='width: 20px; "
+      "height: 100px'></span>text text text");
+
   document().setBaseURLOverride(KURL(ParsedURLString, "http://test.com"));
   setBodyInnerHTML(
       "<style>body { margin: 0; }</style>"
       "<div id=frameContainer>"
-      "  <iframe id=frame src='http://test.com' width='50' height='50' "
+      "  <iframe src='http://test.com' width='50' height='50' "
       "frameBorder='0'></iframe>"
       "</div>");
 
-  Document& frameDocument = setupChildIframe(
-      "frame",
-      "<style>body { margin: 0; }</style><span><img style='width: 20px; "
-      "height: 100px'></span>text text text");
   document().view()->updateAllLifecyclePhases();
 
   LayoutBlock* frameContainer =
       toLayoutBlock(getLayoutObjectByElementId("frameContainer"));
-  LayoutBlock* frameBody = toLayoutBlock(frameDocument.body()->layoutObject());
+  LayoutBlock* frameBody =
+      toLayoutBlock(childDocument().body()->layoutObject());
   LayoutText* frameText = toLayoutText(frameBody->lastChild());
 
   // This case involves clipping: frame height is 50, y-coordinate of result
   // rect is 13, so height should be clipped to (50 - 13) == 37.
-  frameDocument.view()->setScrollOffset(ScrollOffset(0, 47),
-                                        ProgrammaticScroll);
+  childDocument().view()->setScrollOffset(ScrollOffset(0, 47),
+                                          ProgrammaticScroll);
   LayoutRect originalRect(4, 60, 20, 80);
   LayoutRect rect = originalRect;
   EXPECT_TRUE(frameText->mapToVisualRectInAncestorSpace(frameContainer, rect));
   EXPECT_EQ(rect, LayoutRect(4, 13, 20, 37));
 
   rect = originalRect;
   EXPECT_TRUE(frameText->mapToVisualRectInAncestorSpace(&layoutView(), rect));
   EXPECT_EQ(rect, LayoutRect(4, 13, 20, 37));
   checkPaintInvalidationStateRectMapping(rect, originalRect, *frameText,
                                          layoutView(), layoutView());
 
   rect = LayoutRect(4, 60, 0, 80);
   EXPECT_TRUE(frameText->mapToVisualRectInAncestorSpace(frameContainer, rect,
                                                         EdgeInclusive));
   EXPECT_EQ(rect, LayoutRect(4, 13, 0, 37));
 }
 
 TEST_F(VisualRectMappingTest, LayoutViewSubpixelRounding) {
+  setChildFrameHTML(
+      "<style>body { margin: 0; }</style><div id='target' style='position: "
+      "relative; width: 100px; height: 100px; left: 0.5px'>");
+
   document().setBaseURLOverride(KURL(ParsedURLString, "http://test.com"));
   setBodyInnerHTML(
       "<style>body { margin: 0; }</style>"
       "<div id=frameContainer style='position: relative; left: 0.5px'>"
-      "  <iframe id=frame style='position: relative; left: 0.5px' "
+      "  <iframe style='position: relative; left: 0.5px' "
       "src='http://test.com' width='200' height='200' frameBorder='0'></iframe>"
       "</div>");
 
-  Document& frameDocument = setupChildIframe(
-      "frame",
-      "<style>body { margin: 0; }</style><div id='target' style='position: "
-      "relative; width: 100px; height: 100px; left: 0.5px'>");
   document().view()->updateAllLifecyclePhases();
 
   LayoutBlock* frameContainer =
       toLayoutBlock(getLayoutObjectByElementId("frameContainer"));
-  LayoutObject* target = frameDocument.getElementById("target")->layoutObject();
+  LayoutObject* target =
+      childDocument().getElementById("target")->layoutObject();
   LayoutRect rect(0, 0, 100, 100);
   EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(frameContainer, rect));
   // When passing from the iframe to the parent frame, the rect of (0.5, 0, 100,
   // 100) is expanded to (0, 0, 100, 100), and then offset by the 0.5 offset of
   // frameContainer.
   EXPECT_EQ(LayoutRect(LayoutPoint(DoublePoint(0.5, 0)), LayoutSize(101, 100)),
             rect);
 }
 
 TEST_F(VisualRectMappingTest, LayoutViewDisplayNone) {
+  setChildFrameHTML(

[esprehn, 2016/11/18 19:43:02]

Why did you need to rearrange all of these tests?

[dcheng, 2016/11/18 21:16:40]

I reverted this to the original ordering to reduce the size of the diffs. The
design evolved a bit while I was hacking on LayoutTestHelper, and there's no
reason this needs to be reversed anymore.

+      "<style>body { margin: 0; }</style><div "
+      "style='width:100px;height:100px;'></div>");
+
   document().setBaseURLOverride(KURL(ParsedURLString, "http://test.com"));
   setBodyInnerHTML(
       "<style>body { margin: 0; }</style>"
       "<div id=frameContainer>"
-      "  <iframe id=frame src='http://test.com' width='50' height='50' "
+      "  <iframe src='http://test.com' width='50' height='50' "
       "frameBorder='0'></iframe>"
       "</div>");
 
-  Document& frameDocument =
-      setupChildIframe("frame",
-                       "<style>body { margin: 0; }</style><div "
-                       "style='width:100px;height:100px;'></div>");
   document().view()->updateAllLifecyclePhases();
 
   LayoutBlock* frameContainer =
       toLayoutBlock(getLayoutObjectByElementId("frameContainer"));
-  LayoutBlock* frameBody = toLayoutBlock(frameDocument.body()->layoutObject());
+  LayoutBlock* frameBody =
+      toLayoutBlock(childDocument().body()->layoutObject());
   LayoutBlock* frameDiv = toLayoutBlock(frameBody->lastChild());
 
   // This part is copied from the LayoutView test, just to ensure that the
   // mapped rect is valid before display:none is set on the iframe.
-  frameDocument.view()->setScrollOffset(ScrollOffset(0, 47),
-                                        ProgrammaticScroll);
+  childDocument().view()->setScrollOffset(ScrollOffset(0, 47),
+                                          ProgrammaticScroll);
   LayoutRect originalRect(4, 60, 20, 80);
   LayoutRect rect = originalRect;
   EXPECT_TRUE(frameDiv->mapToVisualRectInAncestorSpace(frameContainer, rect));
   EXPECT_EQ(rect, LayoutRect(4, 13, 20, 37));
 
-  Element* frameElement = document().getElementById("frame");
+  Element* frameElement = childDocument().localOwner();

[esprehn, 2016/11/18 19:43:02]

I prefer the getElementById since that's using fewer internal APIs.

[dcheng, 2016/11/18 21:16:40]

Done.

   frameElement->setInlineStyleProperty(CSSPropertyDisplay, "none");
   document().view()->updateAllLifecyclePhases();
 
   rect = originalRect;
   EXPECT_FALSE(frameDiv->mapToVisualRectInAncestorSpace(&layoutView(), rect));
   EXPECT_EQ(rect, LayoutRect());
 }
 
 TEST_F(VisualRectMappingTest, SelfFlippedWritingMode) {
   setBodyInnerHTML(
@@ skipping 461 matching lines @@
   LayoutRect targetVisualRect = target->localVisualRect();
   EXPECT_EQ(LayoutRect(0, 0, 400, 400), targetVisualRect);
   LayoutRect rect = targetVisualRect;
   EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(&layoutView(), rect));
   EXPECT_EQ(LayoutRect(0, 0, 200, 200), rect);
   checkPaintInvalidationStateRectMapping(rect, targetVisualRect, *target,
                                          layoutView(), layoutView());
 }
 
 }  // namespace blink