Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/compiler/verifier.cc

Issue 2504553003: [es6] Perform the IsConstructor test in GetSuperConstructor. (Closed)
Patch Set: Convert GetSuperConstructor to a new interpreter bytecode Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler/typer.cc ('K') | « src/compiler/typer.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | src/interpreter/bytecode-array-builder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 29e6746b7ce39c1a26a2d6a86c6b640ad1c58f7d..3454ec3f8bed54aae5767666007cd9f010c87a7f 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -611,6 +611,10 @@ void Verifier::Visitor::Check(Node* node) {
// Type is String.
CheckTypeIs(node, Type::String());
break;
+ case IrOpcode::kJSGetSuperConstructor:
+ // Type is Function.
Benedikt Meurer 2016/11/23 04:51:00 Nit: Type is Receiver.
+ CheckTypeIs(node, Type::Function());
Benedikt Meurer 2016/11/23 04:51:00 Nit: Type::Receiver
+ break;
case IrOpcode::kJSLoadContext:
// Type can be anything.
« src/compiler/typer.cc ('K') | « src/compiler/typer.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | src/interpreter/bytecode-array-builder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698