Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: src/compiler/js-operator.cc

Issue 2504553003: [es6] Perform the IsConstructor test in GetSuperConstructor. (Closed)
Patch Set: Convert GetSuperConstructor to a new interpreter bytecode Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/js-operator.cc
diff --git a/src/compiler/js-operator.cc b/src/compiler/js-operator.cc
index d39f8cdac57c4a0530064297013d30ae17e79516..90831f8f385e0be2a2c26d04720d317ac43265d1 100644
--- a/src/compiler/js-operator.cc
+++ b/src/compiler/js-operator.cc
@@ -453,7 +453,8 @@ CompareOperationHint CompareOperationHintOf(const Operator* op) {
V(LoadMessage, Operator::kNoThrow, 0, 1) \
V(StoreMessage, Operator::kNoThrow, 1, 0) \
V(GeneratorRestoreContinuation, Operator::kNoThrow, 1, 1) \
- V(StackCheck, Operator::kNoWrite, 0, 0)
+ V(StackCheck, Operator::kNoWrite, 0, 0) \
+ V(GetSuperConstructor, Operator::kNoProperties, 1, 1)
Benedikt Meurer 2016/11/23 04:51:00 This should be marked as Operator::kNoWrite.
Henrique Ferreiro 2016/12/01 12:22:22 Would you mind explaining what would be the differ
Benedikt Meurer 2016/12/01 13:11:51 ToName can call into arbitrary JavaScript (via ToP
#define BINARY_OP_LIST(V) \
V(BitwiseOr) \

Powered by Google App Engine
This is Rietveld 408576698