[es6] Perform the IsConstructor test in GetSuperConstructor.

src/builtins/builtins-object.cc

Index: src/builtins/builtins-object.cc
diff --git a/src/builtins/builtins-object.cc b/src/builtins/builtins-object.cc
index b0bb1f043d6686ccccff6e397ddbcdd0327b92fd..ff1166f298e95874ac77e5a7bc18ebbb72ba842a 100644
--- a/src/builtins/builtins-object.cc
+++ b/src/builtins/builtins-object.cc
@@ -1018,5 +1018,15 @@ void Builtins::Generate_InstanceOf(CodeStubAssembler* assembler) {
   assembler->Return(assembler->InstanceOf(object, callable, context));
 }
 
+void Builtins::Generate_GetSuperConstructor(CodeStubAssembler* assembler) {

[caitp, 2016/11/22 23:42:03]

It looks like this should take a compiler::CodeAssemblerState* parameter, not a
CodeStubAssembler. Based on my read of other TFS stubs, you need to create the
assembler yourself, eg `CodeStubAssembler assembler(state);`

[Benedikt Meurer, 2016/11/23 04:51:00]

Jep, you'll probably hit this once you rebase.

+  typedef compiler::Node Node;
+  typedef TypeofDescriptor Descriptor;
+
+  Node* object = assembler->Parameter(Descriptor::kObject);

[caitp, 2016/11/22 23:30:34]

if `object` is an Smi, GetSuperConstructor() will either crash or do something
weird/undefined.

[Henrique Ferreiro, 2016/12/01 12:22:22]

Shouldn't I check that in CodeStubAssembler::GetSuperConstructor instead of
using a CSA_ASSERT?

[Benedikt Meurer, 2016/12/01 13:11:51]

Yep.

+  Node* context = assembler->Parameter(Descriptor::kContext);
+
+  assembler->Return(assembler->GetSuperConstructor(object, context));
+}
+
 }  // namespace internal
 }  // namespace v8