Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: src/compiler/verifier.cc

Issue 2504553003: [es6] Perform the IsConstructor test in GetSuperConstructor. (Closed)
Patch Set: Fix assembler and add unittest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 case IrOpcode::kJSHasProperty: 628 case IrOpcode::kJSHasProperty:
629 case IrOpcode::kJSInstanceOf: 629 case IrOpcode::kJSInstanceOf:
630 case IrOpcode::kJSOrdinaryHasInstance: 630 case IrOpcode::kJSOrdinaryHasInstance:
631 // Type is Boolean. 631 // Type is Boolean.
632 CheckTypeIs(node, Type::Boolean()); 632 CheckTypeIs(node, Type::Boolean());
633 break; 633 break;
634 case IrOpcode::kJSTypeOf: 634 case IrOpcode::kJSTypeOf:
635 // Type is String. 635 // Type is String.
636 CheckTypeIs(node, Type::String()); 636 CheckTypeIs(node, Type::String());
637 break; 637 break;
638 case IrOpcode::kJSGetSuperConstructor:
639 // Function -> Receiver.
640 CheckValueInputIs(node, 0, Type::Function());
641 CheckTypeIs(node, Type::Receiver());
Benedikt Meurer 2016/12/12 18:18:19 Same: Use Type::Callable here.
642 break;
638 643
639 case IrOpcode::kJSLoadContext: 644 case IrOpcode::kJSLoadContext:
640 // Type can be anything. 645 // Type can be anything.
641 CheckTypeIs(node, Type::Any()); 646 CheckTypeIs(node, Type::Any());
642 break; 647 break;
643 case IrOpcode::kJSStoreContext: 648 case IrOpcode::kJSStoreContext:
644 // Type is empty. 649 // Type is empty.
645 CheckNotTyped(node); 650 CheckNotTyped(node);
646 break; 651 break;
647 case IrOpcode::kJSCreateFunctionContext: 652 case IrOpcode::kJSCreateFunctionContext:
(...skipping 1005 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 replacement->op()->EffectOutputCount() > 0); 1658 replacement->op()->EffectOutputCount() > 0);
1654 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1659 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1655 replacement->opcode() == IrOpcode::kFrameState); 1660 replacement->opcode() == IrOpcode::kFrameState);
1656 } 1661 }
1657 1662
1658 #endif // DEBUG 1663 #endif // DEBUG
1659 1664
1660 } // namespace compiler 1665 } // namespace compiler
1661 } // namespace internal 1666 } // namespace internal
1662 } // namespace v8 1667 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698