Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: src/interpreter/interpreter.cc

Issue 2504553003: [es6] Perform the IsConstructor test in GetSuperConstructor. (Closed)
Patch Set: Convert GetSuperConstructor to a new interpreter bytecode Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/interpreter.h" 5 #include "src/interpreter/interpreter.h"
6 6
7 #include <fstream> 7 #include <fstream>
8 #include <memory> 8 #include <memory>
9 9
10 #include "src/ast/prettyprinter.h" 10 #include "src/ast/prettyprinter.h"
(...skipping 1571 matching lines...) Expand 10 before | Expand all | Expand 10 after
1582 } 1582 }
1583 1583
1584 // DeletePropertySloppy 1584 // DeletePropertySloppy
1585 // 1585 //
1586 // Delete the property specified in the accumulator from the object 1586 // Delete the property specified in the accumulator from the object
1587 // referenced by the register operand following sloppy mode semantics. 1587 // referenced by the register operand following sloppy mode semantics.
1588 void Interpreter::DoDeletePropertySloppy(InterpreterAssembler* assembler) { 1588 void Interpreter::DoDeletePropertySloppy(InterpreterAssembler* assembler) {
1589 DoDelete(Runtime::kDeleteProperty_Sloppy, assembler); 1589 DoDelete(Runtime::kDeleteProperty_Sloppy, assembler);
1590 } 1590 }
1591 1591
1592 void Interpreter::DoGetSuperConstructor(InterpreterAssembler* assembler) {
rmcilroy 2016/11/23 21:55:37 Please add a comment like those above other byteco
1593 Node* active_function = __ GetAccumulator();
1594 Node* context = __ GetContext();
1595 Node* result = assembler->GetSuperConstructor(active_function, context);
1596 __ SetAccumulator(result);
1597 __ Dispatch();
1598 }
1599
1592 void Interpreter::DoJSCall(InterpreterAssembler* assembler, 1600 void Interpreter::DoJSCall(InterpreterAssembler* assembler,
1593 TailCallMode tail_call_mode) { 1601 TailCallMode tail_call_mode) {
1594 Node* function_reg = __ BytecodeOperandReg(0); 1602 Node* function_reg = __ BytecodeOperandReg(0);
1595 Node* function = __ LoadRegister(function_reg); 1603 Node* function = __ LoadRegister(function_reg);
1596 Node* receiver_reg = __ BytecodeOperandReg(1); 1604 Node* receiver_reg = __ BytecodeOperandReg(1);
1597 Node* receiver_arg = __ RegisterLocation(receiver_reg); 1605 Node* receiver_arg = __ RegisterLocation(receiver_reg);
1598 Node* receiver_args_count = __ BytecodeOperandCount(2); 1606 Node* receiver_args_count = __ BytecodeOperandCount(2);
1599 Node* receiver_count = __ Int32Constant(1); 1607 Node* receiver_count = __ Int32Constant(1);
1600 Node* args_count = __ Int32Sub(receiver_args_count, receiver_count); 1608 Node* args_count = __ Int32Sub(receiver_args_count, receiver_count);
1601 Node* slot_id = __ BytecodeOperandIdx(3); 1609 Node* slot_id = __ BytecodeOperandIdx(3);
(...skipping 1035 matching lines...) Expand 10 before | Expand all | Expand 10 after
2637 __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset, 2645 __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
2638 __ SmiTag(new_state)); 2646 __ SmiTag(new_state));
2639 __ SetAccumulator(old_state); 2647 __ SetAccumulator(old_state);
2640 2648
2641 __ Dispatch(); 2649 __ Dispatch();
2642 } 2650 }
2643 2651
2644 } // namespace interpreter 2652 } // namespace interpreter
2645 } // namespace internal 2653 } // namespace internal
2646 } // namespace v8 2654 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698