Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/interpreter/bytecode-array-builder.cc

Issue 2504553003: [es6] Perform the IsConstructor test in GetSuperConstructor. (Closed)
Patch Set: Convert GetSuperConstructor to a new interpreter bytecode Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/bytecode-array-builder.h" 5 #include "src/interpreter/bytecode-array-builder.h"
6 6
7 #include "src/globals.h" 7 #include "src/globals.h"
8 #include "src/interpreter/bytecode-array-writer.h" 8 #include "src/interpreter/bytecode-array-writer.h"
9 #include "src/interpreter/bytecode-dead-code-optimizer.h" 9 #include "src/interpreter/bytecode-dead-code-optimizer.h"
10 #include "src/interpreter/bytecode-label.h" 10 #include "src/interpreter/bytecode-label.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 BytecodeArrayBuilder& BytecodeArrayBuilder::LogicalNot() { 198 BytecodeArrayBuilder& BytecodeArrayBuilder::LogicalNot() {
199 Output(Bytecode::kToBooleanLogicalNot); 199 Output(Bytecode::kToBooleanLogicalNot);
200 return *this; 200 return *this;
201 } 201 }
202 202
203 BytecodeArrayBuilder& BytecodeArrayBuilder::TypeOf() { 203 BytecodeArrayBuilder& BytecodeArrayBuilder::TypeOf() {
204 Output(Bytecode::kTypeOf); 204 Output(Bytecode::kTypeOf);
205 return *this; 205 return *this;
206 } 206 }
207 207
208 BytecodeArrayBuilder& BytecodeArrayBuilder::GetSuperConstructor() {
209 Output(Bytecode::kGetSuperConstructor);
rmcilroy 2016/11/23 21:55:37 This looks like it's on a really old revision of V
210 return *this;
211 }
212
208 BytecodeArrayBuilder& BytecodeArrayBuilder::CompareOperation( 213 BytecodeArrayBuilder& BytecodeArrayBuilder::CompareOperation(
209 Token::Value op, Register reg, int feedback_slot) { 214 Token::Value op, Register reg, int feedback_slot) {
210 switch (op) { 215 switch (op) {
211 case Token::Value::EQ: 216 case Token::Value::EQ:
212 Output(Bytecode::kTestEqual, RegisterOperand(reg), 217 Output(Bytecode::kTestEqual, RegisterOperand(reg),
213 UnsignedOperand(feedback_slot)); 218 UnsignedOperand(feedback_slot));
214 break; 219 break;
215 case Token::Value::NE: 220 case Token::Value::NE:
216 Output(Bytecode::kTestNotEqual, RegisterOperand(reg), 221 Output(Bytecode::kTestNotEqual, RegisterOperand(reg),
217 UnsignedOperand(feedback_slot)); 222 UnsignedOperand(feedback_slot));
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 UNREACHABLE(); // Dealt with in kRegList above. 935 UNREACHABLE(); // Dealt with in kRegList above.
931 } 936 }
932 } 937 }
933 938
934 return true; 939 return true;
935 } 940 }
936 941
937 } // namespace interpreter 942 } // namespace interpreter
938 } // namespace internal 943 } // namespace internal
939 } // namespace v8 944 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698