Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: src/compiler/verifier.cc

Issue 2504553003: [es6] Perform the IsConstructor test in GetSuperConstructor. (Closed)
Patch Set: Convert GetSuperConstructor to a new interpreter bytecode Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 case IrOpcode::kJSDeleteProperty: 604 case IrOpcode::kJSDeleteProperty:
605 case IrOpcode::kJSHasProperty: 605 case IrOpcode::kJSHasProperty:
606 case IrOpcode::kJSInstanceOf: 606 case IrOpcode::kJSInstanceOf:
607 // Type is Boolean. 607 // Type is Boolean.
608 CheckTypeIs(node, Type::Boolean()); 608 CheckTypeIs(node, Type::Boolean());
609 break; 609 break;
610 case IrOpcode::kJSTypeOf: 610 case IrOpcode::kJSTypeOf:
611 // Type is String. 611 // Type is String.
612 CheckTypeIs(node, Type::String()); 612 CheckTypeIs(node, Type::String());
613 break; 613 break;
614 case IrOpcode::kJSGetSuperConstructor:
615 // Type is Function.
Benedikt Meurer 2016/11/23 04:51:00 Nit: Type is Receiver.
616 CheckTypeIs(node, Type::Function());
Benedikt Meurer 2016/11/23 04:51:00 Nit: Type::Receiver
617 break;
614 618
615 case IrOpcode::kJSLoadContext: 619 case IrOpcode::kJSLoadContext:
616 // Type can be anything. 620 // Type can be anything.
617 CheckTypeIs(node, Type::Any()); 621 CheckTypeIs(node, Type::Any());
618 break; 622 break;
619 case IrOpcode::kJSStoreContext: 623 case IrOpcode::kJSStoreContext:
620 // Type is empty. 624 // Type is empty.
621 CheckNotTyped(node); 625 CheckNotTyped(node);
622 break; 626 break;
623 case IrOpcode::kJSCreateFunctionContext: 627 case IrOpcode::kJSCreateFunctionContext:
(...skipping 993 matching lines...) Expand 10 before | Expand all | Expand 10 after
1617 replacement->op()->EffectOutputCount() > 0); 1621 replacement->op()->EffectOutputCount() > 0);
1618 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1622 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1619 replacement->opcode() == IrOpcode::kFrameState); 1623 replacement->opcode() == IrOpcode::kFrameState);
1620 } 1624 }
1621 1625
1622 #endif // DEBUG 1626 #endif // DEBUG
1623 1627
1624 } // namespace compiler 1628 } // namespace compiler
1625 } // namespace internal 1629 } // namespace internal
1626 } // namespace v8 1630 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698