Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2504543003: [GeometryInterface] Add Constructor() at DOMMatrixReadOnly. (Closed)

Created:
4 years, 1 month ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee(hs1217.lee), rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] Add Constructor() at DOMMatrixReadOnly. Return the result of invoking create a 2d matrix of type DOMMatrixReadOnly, with the sequence [1, 0, 0, 1, 0, 0]. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-dommatrixreadonly BUG=388780, 665436 Committed: https://crrev.com/4747cd0088a0b1dbf5841da1266b5667a3ab8019 Cr-Commit-Position: refs/heads/master@{#433099}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
Hwanseung Lee
@dominicc, zino PTAL, thank you.
4 years, 1 month ago (2016-11-15 14:40:44 UTC) #2
dominicc (has gone to gerrit)
lgtm
4 years, 1 month ago (2016-11-17 03:06:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504543003/1
4 years, 1 month ago (2016-11-17 03:08:34 UTC) #9
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-17 05:30:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504543003/20001
4 years, 1 month ago (2016-11-17 15:17:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/264294)
4 years, 1 month ago (2016-11-17 16:51:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504543003/20001
4 years, 1 month ago (2016-11-17 23:11:28 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/340136)
4 years, 1 month ago (2016-11-18 01:37:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504543003/20001
4 years, 1 month ago (2016-11-18 04:19:15 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 04:25:48 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:33:00 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4747cd0088a0b1dbf5841da1266b5667a3ab8019
Cr-Commit-Position: refs/heads/master@{#433099}

Powered by Google App Engine
This is Rietveld 408576698