[Reland-fixing asan failure] Tablet-like power button behavior on Convertible/Tablet ChromeOS devic…

[Reland-fixing asan failure] Tablet-like power button behavior on Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior described in go/touchview-power convertible behavior; other devices follow clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two threads, UI thread and DBusThread. Thus raw pointer may cause "use after free address error".

BUG=633304
TEST=manually test; add unitttest; manually asan test.

Committed: https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73
Cr-Commit-Position: refs/heads/master@{#432196}

[Qiang(Joe) Xu, 2016-11-15 05:21:52]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[Qiang(Joe) Xu, 2016-11-15 05:22:01]

Description was changed from

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

to

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

[Qiang(Joe) Xu, 2016-11-15 05:22:01]

warx@chromium.org changed reviewers:
+ derat@chromium.org

[commit-bot: I haz the power, 2016-11-15 05:22:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2016-11-15 05:26:08]

Description was changed from

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

to

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior
described in go/touchview-power convertible behavior; other devices follow
clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two
threads, UI thread and DBusThread. Thus raw pointer may cause "use after free
address error".

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

[Qiang(Joe) Xu, 2016-11-15 05:31:45]

Hi Daniel, please review this first and then
https://codereview.chromium.org/2506493002/, thanks!

[commit-bot: I haz the power, 2016-11-15 09:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 09:24:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Erat, 2016-11-15 15:08:20]

lgtm

[Qiang(Joe) Xu, 2016-11-15 16:24:20]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2016-11-15 16:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 16:46:02]

Description was changed from

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior
described in go/touchview-power convertible behavior; other devices follow
clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two
threads, UI thread and DBusThread. Thus raw pointer may cause "use after free
address error".

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

to

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior
described in go/touchview-power convertible behavior; other devices follow
clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two
threads, UI thread and DBusThread. Thus raw pointer may cause "use after free
address error".

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

[commit-bot: I haz the power, 2016-11-15 16:46:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 16:50:38]

Description was changed from

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior
described in go/touchview-power convertible behavior; other devices follow
clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two
threads, UI thread and DBusThread. Thus raw pointer may cause "use after free
address error".

BUG=633304
TEST=manually test; add unitttest; manually asan test.
==========

to

==========
[Reland-fixing asan failure] Tablet-like power button behavior on
Convertible/Tablet ChromeOS devices

description from 2474913004:
Changes:
device consistency: convertible/tablet chromeos devices follow the behavior
described in go/touchview-power convertible behavior; other devices follow
clamshell behavior.

description for this review:
The CL in 2474913004 using raw pointer for callback. However, there are two
threads, UI thread and DBusThread. Thus raw pointer may cause "use after free
address error".

BUG=633304
TEST=manually test; add unitttest; manually asan test.

Committed: https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73
Cr-Commit-Position: refs/heads/master@{#432196}
==========

[commit-bot: I haz the power, 2016-11-15 16:50:41]

Patchset 2 (id:??) landed as
https://crrev.com/168ffcf4f0f154cc52d7428f18e90b7d2c5ffb73
Cr-Commit-Position: refs/heads/master@{#432196}