chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc - Issue 2504513002: Make FakeChromeUserManager subclass of ChromeUserManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

Issue 2504513002: Make FakeChromeUserManager subclass of ChromeUserManager (Closed)

Patch Set: Addressed comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc ('k') | chrome/browser/chromeos/settings/session_manager_operation_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

diff --git a/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc b/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

index 6852b0051ab3b967581e928470f9b123114105da..1dd57051bcfd085e9745291f3b06dcc7b5681822 100644

--- a/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

+++ b/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

@@ -13,6 +13,7 @@

#include "base/run_loop.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

+#include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"

#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"

#include "chrome/browser/chromeos/printer_detector/printer_detector_factory.h"

#include "chrome/browser/chromeos/profiles/profile_helper.h"

@@ -21,7 +22,6 @@

#include "chrome/browser/notifications/notification_test_util.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/test/base/testing_profile.h"

-#include "components/user_manager/fake_user_manager.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "device/base/mock_device_client.h"

#include "device/usb/mock_usb_device.h"

@@ -62,7 +62,7 @@ std::unique_ptr<KeyedService> CreatePrinterDetector(

class PrinterDetectorAppSearchEnabledTest : public testing::Test {

public:

PrinterDetectorAppSearchEnabledTest()

- : user_manager_(new user_manager::FakeUserManager()),

+ : user_manager_(new chromeos::FakeChromeUserManager()),

user_manager_enabler_(user_manager_) {}

~PrinterDetectorAppSearchEnabledTest() override = default;

@@ -135,7 +135,7 @@ class PrinterDetectorAppSearchEnabledTest : public testing::Test {

content::TestBrowserThreadBundle thread_bundle_;

StubNotificationUIManager notification_ui_manager_;

- user_manager::FakeUserManager* user_manager_;

+ chromeos::FakeChromeUserManager* user_manager_;

chromeos::ScopedUserManagerEnabler user_manager_enabler_;

device::MockDeviceClient device_client_;

std::unique_ptr<TestingProfile> profile_;