Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc

Issue 2504513002: Make FakeChromeUserManager subclass of ChromeUserManager (Closed)
Patch Set: Addressed comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/external_provider_impl.h" 5 #include "chrome/browser/extensions/external_provider_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/test/scoped_path_override.h" 11 #include "base/test/scoped_path_override.h"
12 #include "chrome/browser/chrome_notification_types.h" 12 #include "chrome/browser/chrome_notification_types.h"
13 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h" 13 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
14 #include "chrome/browser/chromeos/customization/customization_document.h" 14 #include "chrome/browser/chromeos/customization/customization_document.h"
15 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
15 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h" 16 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
16 #include "chrome/browser/extensions/extension_service.h" 17 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/extension_service_test_base.h" 18 #include "chrome/browser/extensions/extension_service_test_base.h"
18 #include "chrome/browser/prefs/pref_service_syncable_util.h" 19 #include "chrome/browser/prefs/pref_service_syncable_util.h"
19 #include "chrome/browser/profiles/profile_manager.h" 20 #include "chrome/browser/profiles/profile_manager.h"
20 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" 21 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
21 #include "chrome/browser/signin/signin_manager_factory.h" 22 #include "chrome/browser/signin/signin_manager_factory.h"
22 #include "chrome/browser/sync/profile_sync_service_factory.h" 23 #include "chrome/browser/sync/profile_sync_service_factory.h"
23 #include "chrome/common/chrome_paths.h" 24 #include "chrome/common/chrome_paths.h"
24 #include "chrome/common/chrome_switches.h" 25 #include "chrome/common/chrome_switches.h"
25 #include "chrome/test/base/testing_browser_process.h" 26 #include "chrome/test/base/testing_browser_process.h"
26 #include "chrome/test/base/testing_profile.h" 27 #include "chrome/test/base/testing_profile.h"
27 #include "chromeos/system/fake_statistics_provider.h" 28 #include "chromeos/system/fake_statistics_provider.h"
28 #include "chromeos/system/statistics_provider.h" 29 #include "chromeos/system/statistics_provider.h"
29 #include "components/browser_sync/browser_sync_switches.h" 30 #include "components/browser_sync/browser_sync_switches.h"
30 #include "components/browser_sync/profile_sync_service.h" 31 #include "components/browser_sync/profile_sync_service.h"
31 #include "components/signin/core/browser/profile_oauth2_token_service.h" 32 #include "components/signin/core/browser/profile_oauth2_token_service.h"
32 #include "components/signin/core/browser/signin_manager_base.h" 33 #include "components/signin/core/browser/signin_manager_base.h"
33 #include "components/sync/base/pref_names.h" 34 #include "components/sync/base/pref_names.h"
34 #include "components/sync/model/fake_sync_change_processor.h" 35 #include "components/sync/model/fake_sync_change_processor.h"
35 #include "components/sync/model/sync_change_processor.h" 36 #include "components/sync/model/sync_change_processor.h"
36 #include "components/sync/model/sync_error_factory_mock.h" 37 #include "components/sync/model/sync_error_factory_mock.h"
37 #include "components/sync_preferences/pref_service_syncable.h" 38 #include "components/sync_preferences/pref_service_syncable.h"
38 #include "components/user_manager/fake_user_manager.h"
39 #include "content/public/browser/notification_service.h" 39 #include "content/public/browser/notification_service.h"
40 #include "content/public/test/test_utils.h" 40 #include "content/public/test/test_utils.h"
41 41
42 namespace extensions { 42 namespace extensions {
43 43
44 namespace { 44 namespace {
45 45
46 const char kExternalAppId[] = "kekdneafjmhmndejhmbcadfiiofngffo"; 46 const char kExternalAppId[] = "kekdneafjmhmndejhmbcadfiiofngffo";
47 const char kStandaloneAppId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf"; 47 const char kStandaloneAppId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
48 48
49 class ExternalProviderImplChromeOSTest : public ExtensionServiceTestBase { 49 class ExternalProviderImplChromeOSTest : public ExtensionServiceTestBase {
50 public: 50 public:
51 ExternalProviderImplChromeOSTest() 51 ExternalProviderImplChromeOSTest()
52 : fake_user_manager_(new user_manager::FakeUserManager()), 52 : fake_user_manager_(new chromeos::FakeChromeUserManager()),
53 scoped_user_manager_(fake_user_manager_) {} 53 scoped_user_manager_(fake_user_manager_) {}
54 54
55 ~ExternalProviderImplChromeOSTest() override {} 55 ~ExternalProviderImplChromeOSTest() override {}
56 56
57 void InitServiceWithExternalProviders(bool standalone) { 57 void InitServiceWithExternalProviders(bool standalone) {
58 InitializeEmptyExtensionService(); 58 InitializeEmptyExtensionService();
59 service_->Init(); 59 service_->Init();
60 60
61 if (standalone) { 61 if (standalone) {
62 external_externsions_overrides_.reset(new base::ScopedPathOverride( 62 external_externsions_overrides_.reset(new base::ScopedPathOverride(
(...skipping 17 matching lines...) Expand all
80 ExtensionServiceTestBase::SetUp(); 80 ExtensionServiceTestBase::SetUp();
81 } 81 }
82 82
83 void TearDown() override { 83 void TearDown() override {
84 chromeos::KioskAppManager::Shutdown(); 84 chromeos::KioskAppManager::Shutdown();
85 } 85 }
86 86
87 private: 87 private:
88 std::unique_ptr<base::ScopedPathOverride> external_externsions_overrides_; 88 std::unique_ptr<base::ScopedPathOverride> external_externsions_overrides_;
89 chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_; 89 chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
90 user_manager::FakeUserManager* fake_user_manager_; 90 chromeos::FakeChromeUserManager* fake_user_manager_;
91 chromeos::ScopedUserManagerEnabler scoped_user_manager_; 91 chromeos::ScopedUserManagerEnabler scoped_user_manager_;
92 92
93 DISALLOW_COPY_AND_ASSIGN(ExternalProviderImplChromeOSTest); 93 DISALLOW_COPY_AND_ASSIGN(ExternalProviderImplChromeOSTest);
94 }; 94 };
95 95
96 } // namespace 96 } // namespace
97 97
98 // Normal mode, external app should be installed. 98 // Normal mode, external app should be installed.
99 TEST_F(ExternalProviderImplChromeOSTest, Normal) { 99 TEST_F(ExternalProviderImplChromeOSTest, Normal) {
100 InitServiceWithExternalProviders(false); 100 InitServiceWithExternalProviders(false);
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 new syncer::SyncErrorFactoryMock())); 203 new syncer::SyncErrorFactoryMock()));
204 204
205 content::WindowedNotificationObserver( 205 content::WindowedNotificationObserver(
206 extensions::NOTIFICATION_CRX_INSTALLER_DONE, 206 extensions::NOTIFICATION_CRX_INSTALLER_DONE,
207 content::NotificationService::AllSources()).Wait(); 207 content::NotificationService::AllSources()).Wait();
208 208
209 EXPECT_TRUE(service_->GetInstalledExtension(kStandaloneAppId)); 209 EXPECT_TRUE(service_->GetInstalledExtension(kStandaloneAppId));
210 } 210 }
211 211
212 } // namespace extensions 212 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698