Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 25045010: Change SimpleFontData::platformBoundsForGlyph to use getTextPath (Closed)

Created:
7 years, 2 months ago by eae
Modified:
7 years, 2 months ago
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, jeez, pdr.
Visibility:
Public.

Description

Change SimpleFontData::platformBoundsForGlyph to use getTextPath On skia platforms we currnetly implement platformBoundsForGlyph by using the measureText API. This returns a conservative bounding box intended for paint but it is close enough to the actual metrics in most cases. For vertical text however it tends to overly inflated. Change it to use the getTextPath API instead which returns more precise metrics instead for text metrics. BUG=249099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158584

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Messages

Total messages: 5 (0 generated)
eae
The new pixel results all show _less_ red than before and for the text ones ...
7 years, 2 months ago (2013-09-30 22:43:26 UTC) #1
leviw_travelin_and_unemployed
nit: "concervative" in description. LGTM. https://codereview.chromium.org/25045010/diff/6001/Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp File Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp (right): https://codereview.chromium.org/25045010/diff/6001/Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp#newcode227 Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp:227: // fallback can go ...
7 years, 2 months ago (2013-09-30 22:46:59 UTC) #2
eae
On 2013/09/30 22:46:59, Levi wrote: > nit: "concervative" in description. Fixed, thanks. > https://codereview.chromium.org/25045010/diff/6001/Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp#newcode227 > ...
7 years, 2 months ago (2013-09-30 22:48:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/25045010/6001
7 years, 2 months ago (2013-09-30 22:49:17 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 03:13:06 UTC) #5
Message was sent while issue was closed.
Change committed as 158584

Powered by Google App Engine
This is Rietveld 408576698