HTTP GM results viewer: server now returns category summaries along with testData

HTTP GM results viewer: server now returns category summaries along with testData

(SkipBuildbotRuns)

R=borenet@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11520

[epoger, 2013-09-27 18:12:39]

Ready for review at patchset 2.

And it's running at http://c128.i.corp.google.com:8888/ , if you want to check
it out.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
gm/rebaseline_server/results.py:58: "categories": # dictionary of category
totals, keyed by category name
This "categories" dict is the new part.  By including this summary, we allow the
web client to present sorting/filtering UIs without having to parse every test
result.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:30: <option ng-repeat="(resultType, count)
in categories['resultType']"
For now, I'm still showing the resultTypes in a dropdown, but now that dropdown
shows how many results there are of each type.

In a future CL, I will allow filtering on multiple categories, not just
resultTypes.

[bsalomon, 2013-09-27 18:15:13]

On 2013/09/27 18:12:39, epoger wrote:
> Ready for review at patchset 2.
> 
> And it's running at http://c128.i.corp.google.com:8888/ , if you want to check
> it out.
> 
>
https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
> File gm/rebaseline_server/results.py (right):
> 
>
https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
> gm/rebaseline_server/results.py:58: "categories": # dictionary of category
> totals, keyed by category name
> This "categories" dict is the new part.  By including this summary, we allow
the
> web client to present sorting/filtering UIs without having to parse every test
> result.
> 
>
https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
> File gm/rebaseline_server/static/view.html (right):
> 
>
https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
> gm/rebaseline_server/static/view.html:30: <option ng-repeat="(resultType,
count)
> in categories['resultType']"
> For now, I'm still showing the resultTypes in a dropdown, but now that
dropdown
> shows how many results there are of each type.
> 
> In a future CL, I will allow filtering on multiple categories, not just
> resultTypes.

Hey Elliot, when I first load the page it looks it is showing me failures but
the drop-down text is blank.

[epoger, 2013-09-27 18:16:27]

On 2013/09/27 18:15:13, bsalomon wrote:
> Hey Elliot, when I first load the page it looks it is showing me failures but
> the drop-down text is blank.

Yeah, I see that same behavior.  I wasn't going to worry about that for now,
given that the drop-down will be going away in the next CL.

Let me know if you think it's important to pursue, and I will.

[bsalomon, 2013-09-27 18:21:04]

On 2013/09/27 18:16:27, epoger wrote:
> On 2013/09/27 18:15:13, bsalomon wrote:
> > Hey Elliot, when I first load the page it looks it is showing me failures
but
> > the drop-down text is blank.
> 
> Yeah, I see that same behavior.  I wasn't going to worry about that for now,
> given that the drop-down will be going away in the next CL.
> 
> Let me know if you think it's important to pursue, and I will.

sgtm

[borenet, 2013-09-27 19:22:01]

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
gm/rebaseline_server/results.py:58: "categories": # dictionary of category
totals, keyed by category name
On 2013/09/27 18:12:39, epoger wrote:
> This "categories" dict is the new part.  By including this summary, we allow
the
> web client to present sorting/filtering UIs without having to parse every test
> result.

I'm confused - "resultType" and "builder" are the categories?  Can we add some
more comments?  It looks like only "resultType" is being used.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
gm/rebaseline_server/results.py:71:
"Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release": 180,
What does 180 mean?  Is that the total number of results for this builder?

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:30: <option ng-repeat="(resultType, count)
in categories['resultType']"
On 2013/09/27 18:12:39, epoger wrote:
> For now, I'm still showing the resultTypes in a dropdown, but now that
dropdown
> shows how many results there are of each type.
> 
> In a future CL, I will allow filtering on multiple categories, not just
> resultTypes.

Please pre-select the category that you're displaying on page load.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:54: maxlength="4"/>
Can you make this only update the image size when a button is pressed, or on
"enter", lost focus, etc?  That will save a lot of work when this feature is
used.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:59: Click on each column header to re-sort
by that column...<br>
Can we at least make the column headers change the cursor on mouseover?  It's
not clear (except from this label) that clicking on them should do anything. 
Also, I can sort by the images, which I don't think makes much sense.

[epoger, 2013-09-27 21:38:13]

Thanks, Eric. Please see patchset 3 (and the updated behavior on the server).

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
gm/rebaseline_server/results.py:58: "categories": # dictionary of category
totals, keyed by category name
On 2013/09/27 19:22:01, borenet wrote:
> On 2013/09/27 18:12:39, epoger wrote:
> > This "categories" dict is the new part.  By including this summary, we allow
> the
> > web client to present sorting/filtering UIs without having to parse every
test
> > result.
> 
> I'm confused - "resultType" and "builder" are the categories?  Can we add some
> more comments?  It looks like only "resultType" is being used.

I updated the docstring to (hopefully) make it clearer.

Currently, only "resultType" is being used by view.html, but I plan to change
that in another CL soon.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
gm/rebaseline_server/results.py:71:
"Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release": 180,
On 2013/09/27 19:22:01, borenet wrote:
> What does 180 mean?  Is that the total number of results for this builder?

That's what the number at that position represents, yes.  180 was a wild guess,
which was off by an order of magnitude.  I have updated all the numbers in this
docstring, using current results.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:30: <option ng-repeat="(resultType, count)
in categories['resultType']"
On 2013/09/27 19:22:01, borenet wrote:
> On 2013/09/27 18:12:39, epoger wrote:
> > For now, I'm still showing the resultTypes in a dropdown, but now that
> dropdown
> > shows how many results there are of each type.
> > 
> > In a future CL, I will allow filtering on multiple categories, not just
> > resultTypes.
> 
> Please pre-select the category that you're displaying on page load.

Unfortunately, for the reasons outlined in
http://stackoverflow.com/questions/15326164/setting-the-selected-item-in-angu...
, that is tricky to do.

Given that the dropdown list will be going away very soon in favor of
sorting/filtering on all columns (as described in the TODO above), I would
rather leave it as-is if that's OK with you.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:54: maxlength="4"/>
On 2013/09/27 19:22:01, borenet wrote:
> Can you make this only update the image size when a button is pressed, or on
> "enter", lost focus, etc?  That will save a lot of work when this feature is
> used.

Added an "apply" button.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:59: Click on each column header to re-sort
by that column...<br>
On 2013/09/27 19:22:01, borenet wrote:
> Can we at least make the column headers change the cursor on mouseover?  It's
> not clear (except from this label) that clicking on them should do anything. 

In the long term, improving the column sorting as alluded to in the TODO below
will make this clearer (and allow sort-up and sort-down).

In the meanwhile, I made the headers buttons... is that clearer?

> Also, I can sort by the images, which I don't think makes much sense.

Au contraire... I like that I can see all tests which resulted in identical
images, all in one bunch.  But if you don't like that, I recommend you don't
click there. :-)

[borenet, 2013-09-30 13:06:02]

I'm not completely happy with the UI, but LGTM since this is a work in progress
and that will change.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/resul...
gm/rebaseline_server/results.py:58: "categories": # dictionary of category
totals, keyed by category name
On 2013/09/27 21:38:13, epoger wrote:
> On 2013/09/27 19:22:01, borenet wrote:
> > On 2013/09/27 18:12:39, epoger wrote:
> > > This "categories" dict is the new part.  By including this summary, we
allow
> > the
> > > web client to present sorting/filtering UIs without having to parse every
> test
> > > result.
> > 
> > I'm confused - "resultType" and "builder" are the categories?  Can we add
some
> > more comments?  It looks like only "resultType" is being used.
> 
> I updated the docstring to (hopefully) make it clearer.
> 
> Currently, only "resultType" is being used by view.html, but I plan to change
> that in another CL soon.

Thanks Elliot.  This is much clearer.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:30: <option ng-repeat="(resultType, count)
in categories['resultType']"
On 2013/09/27 21:38:13, epoger wrote:
> On 2013/09/27 19:22:01, borenet wrote:
> > On 2013/09/27 18:12:39, epoger wrote:
> > > For now, I'm still showing the resultTypes in a dropdown, but now that
> > dropdown
> > > shows how many results there are of each type.
> > > 
> > > In a future CL, I will allow filtering on multiple categories, not just
> > > resultTypes.
> > 
> > Please pre-select the category that you're displaying on page load.
> 
> Unfortunately, for the reasons outlined in
>
http://stackoverflow.com/questions/15326164/setting-the-selected-item-in-angu...
> , that is tricky to do.
> 
> Given that the dropdown list will be going away very soon in favor of
> sorting/filtering on all columns (as described in the TODO above), I would
> rather leave it as-is if that's OK with you.

I know nothing of angular, but in jinja/django I think you could add something
like this in your option tag:

selected="{{ 1 if resultType == showResultsOfType else 0 }}"

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:59: Click on each column header to re-sort
by that column...<br>
On 2013/09/27 21:38:13, epoger wrote:
> On 2013/09/27 19:22:01, borenet wrote:
> > Can we at least make the column headers change the cursor on mouseover? 
It's
> > not clear (except from this label) that clicking on them should do anything.

> 
> In the long term, improving the column sorting as alluded to in the TODO below
> will make this clearer (and allow sort-up and sort-down).
> 
> In the meanwhile, I made the headers buttons... is that clearer?
> 

I think the clearest thing is something like a radio button, which displays just
the column header when not selected and displays an arrow when selected. 
Something like what we see on the issue tracker, although that's even simpler in
that it just displays arrows next to every column header.  Using an anchor tag
with href="#" should get you the right mouse pointer.

> > Also, I can sort by the images, which I don't think makes much sense.
> 
> Au contraire... I like that I can see all tests which resulted in identical
> images, all in one bunch.  But if you don't like that, I recommend you don't
> click there. :-)
> 

Fair enough!

https://codereview.chromium.org/25045003/diff/21001/gm/rebaseline_server/resu...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/25045003/diff/21001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:60: # each category's value appears in the test
results
I might adjust this to say, "number of times each value within the category
appears"

[epoger, 2013-09-30 15:04:58]

Thanks, Eric.  Made some final tweaks based on your comments, committing now.

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:59: Click on each column header to re-sort
by that column...<br>
On 2013/09/30 13:06:02, borenet wrote:
> I think the clearest thing is something like a radio button, which displays
just
> the column header when not selected and displays an arrow when selected. 

Good idea.  Changed 'em to radio buttons for now.

> Something like what we see on the issue tracker, although that's even simpler
in
> that it just displays arrows next to every column header.  Using an anchor tag
> with href="#" should get you the right mouse pointer.

I will improve the sort UI soon, aiming for something along the lines of
http://jsfiddle.net/vojtajina/js64b/14/

https://codereview.chromium.org/25045003/diff/21001/gm/rebaseline_server/resu...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/25045003/diff/21001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:60: # each category's value appears in the test
results
On 2013/09/30 13:06:02, borenet wrote:
> I might adjust this to say, "number of times each value within the category
> appears"

Done.

[epoger, 2013-09-30 15:06:33]

Committed patchset #5 manually as r11520 (presubmit successful).

[borenet, 2013-09-30 15:31:23]

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/25045003/diff/3001/gm/rebaseline_server/stati...
gm/rebaseline_server/static/view.html:59: Click on each column header to re-sort
by that column...<br>
On 2013/09/30 15:04:59, epoger wrote:
> On 2013/09/30 13:06:02, borenet wrote:
> > I think the clearest thing is something like a radio button, which displays
> just
> > the column header when not selected and displays an arrow when selected. 
> 
> Good idea.  Changed 'em to radio buttons for now.
> 
> > Something like what we see on the issue tracker, although that's even
simpler
> in
> > that it just displays arrows next to every column header.  Using an anchor
tag
> > with href="#" should get you the right mouse pointer.
> 
> I will improve the sort UI soon, aiming for something along the lines of
> http://jsfiddle.net/vojtajina/js64b/14/

SGTM.  That example looks great.