Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25045002: Rebaseline hairline images & remove suppression (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
epoger
CC:
bsalomon, skia-review_googlegroups.com
Visibility:
Public.

Description

Rebaseline hairline images & remove suppression

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -168 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 3 chunks +10 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 3 chunks +10 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 8 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 7 chunks +9 lines, -9 lines 1 comment Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Here's were I am so far.
7 years, 2 months ago (2013-09-27 13:20:19 UTC) #1
robertphillips
committed as r11496
7 years, 2 months ago (2013-09-27 13:34:17 UTC) #2
epoger
7 years, 2 months ago (2013-09-27 14:10:05 UTC) #3
Message was sent while issue was closed. 
LGTM (rubberstamp, I don't have a good way of actually reviewing the pixel
diffs)

https://codereview.chromium.org/25045002/diff/1/expectations/gm/Test-Mac10.6-...
File
expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json
(right):

https://codereview.chromium.org/25045002/diff/1/expectations/gm/Test-Mac10.6-...
expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json:5446:
"ignore-failure": true,
These unrelated changes are just JSON style fixes... in the recent past, someone
manually modified these expectations in a legal but
not-quite-matching-rebaseline.pys-style manner.

Powered by Google App Engine
This is Rietveld 408576698