Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2504493002: [Devtools] Remove popover on click initiator column (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Remove popover on click initiator column Fixes a regression that when an initiator was clicked in network it would not hide when the panel was hidden. R=dgozman,lushnikov BUG=663676 Committed: https://crrev.com/d3b5491c9bafc5fdfd81359a5b49cbe9e4d99496 Cr-Commit-Position: refs/heads/master@{#432243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
allada
PTL
4 years, 1 month ago (2016-11-15 16:37:46 UTC) #1
dgozman
lgtm Let's add tests for new waterfall!
4 years, 1 month ago (2016-11-15 17:47:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504493002/1
4 years, 1 month ago (2016-11-15 20:02:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 20:14:59 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 20:20:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3b5491c9bafc5fdfd81359a5b49cbe9e4d99496
Cr-Commit-Position: refs/heads/master@{#432243}

Powered by Google App Engine
This is Rietveld 408576698