components/sync/driver/sync_service.h - Issue 2504433002: [Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/sync_service.h

Issue 2504433002: [Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled. (Closed)

Patch Set: Fixed sessions extensions test, added a pss unittest. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/sync_service.h

diff --git a/components/sync/driver/sync_service.h b/components/sync/driver/sync_service.h

index 40528c4622ef8d835c481342cdfacd9b45cf870b..708a606ef2a821461f86355a0493133cb93a7894 100644

--- a/components/sync/driver/sync_service.h

+++ b/components/sync/driver/sync_service.h

@@ -205,8 +205,8 @@ class SyncService : public DataTypeEncryptionHandler {

// (such as deciding when to prompt for an encryption passphrase).

virtual bool IsBackendInitialized() const = 0;

- // Return the active OpenTabsUIDelegate. If sessions is not enabled or not

- // currently syncing, returns nullptr.

+ // Return the active OpenTabsUIDelegate. If open/proxy tabs is not enabled or

+ // not currently syncing, returns nullptr.

virtual sync_sessions::OpenTabsUIDelegate* GetOpenTabsUIDelegate() = 0;

// Returns true if OnPassphraseRequired has been called for decryption and