[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Previously each UI component that relied on this would have its separate checks to see if PROXY_TABS was enabled or not, and only display the tabs data from the OpenTabsUIDelegate if it was. As more UI was created that relied on foreign tabs data, we saw the mistake of not making this check occur multiple times.

This change will result in a null OpenTabsUIDelegate being provided when proxy tabs is disabled, and it will be impossible to make the mentioned mistake.

Going forward, there are a handful of places with logic that checks and/or passes around if proxy tabs is enabled or not. As a follow up to this CL, we should go through and remove/simplify all that logic as foreign tabs data will no longer be accessible when proxy tabs becomes disabled.

BUG=662601
Committed: https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f
Cr-Commit-Position: refs/heads/master@{#432227}

[skym, 2016-11-14 19:44:03]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 19:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-11-14 19:49:58]

Description was changed from

==========
[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

BUG=662601
==========

to

==========
[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Previously each UI component that relied on this would have its separate checks
to see if PROXY_TABS was enabled or not, and only display the tabs data from the
OpenTabsUIDelegate if it was. As more UI was created that relied on foreign tabs
data, we saw the mistake of not making this check occur multiple times.

This change will result in a null OpenTabsUIDelegate being provided when proxy
tabs is disabled, and it will be impossible to make the mentioned mistake.

Going forward, there are a handful of places with logic that checks and/or
passes around if proxy tabs is enabled or not. As a follow up to this CL, we
should go through and remove/simplify all that logic as foreign tabs data will
no longer be accessible when proxy tabs becomes disabled.


BUG=662601
==========

[skym, 2016-11-14 19:49:58]

skym@chromium.org changed reviewers:
+ zea@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:43:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2016-11-14 22:06:02]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 22:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-11-14 22:44:46]

PTAL

[Nicolas Zea, 2016-11-14 22:53:48]

lgtm

https://codereview.chromium.org/2504433002/diff/20001/components/browser_sync...
File components/browser_sync/profile_sync_service_unittest.cc (right):

https://codereview.chromium.org/2504433002/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service_unittest.cc:962:
TEST_F(ProfileSyncServiceTest, Skym) {
Update test name?

[commit-bot: I haz the power, 2016-11-14 23:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:17:48]

Dry run: This issue passed the CQ dry run.

[skym, 2016-11-15 16:53:39]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 16:54:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-11-15 16:54:25]

skym@chromium.org changed reviewers:
+ reillyg@google.com

[skym, 2016-11-15 16:54:26]

Adding reillyg@ for chrome/browser/extensions/api/sessions/sessions_apitest.cc

https://codereview.chromium.org/2504433002/diff/20001/components/browser_sync...
File components/browser_sync/profile_sync_service_unittest.cc (right):

https://codereview.chromium.org/2504433002/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service_unittest.cc:962:
TEST_F(ProfileSyncServiceTest, Skym) {
On 2016/11/14 22:53:48, Nicolas Zea wrote:
> Update test name?

Whooooops. Thanks for catching that, Done.

[Reilly Grant (use Gerrit), 2016-11-15 17:36:18]

reillyg@chromium.org changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-11-15 17:36:19]

lgtm

[skym, 2016-11-15 17:58:09]

skym@chromium.org changed reviewers:
- reillyg@google.com

[commit-bot: I haz the power, 2016-11-15 18:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 18:24:11]

Dry run: This issue passed the CQ dry run.

[skym, 2016-11-15 18:49:41]

The CQ bit was checked by skym@chromium.org

[skym, 2016-11-15 18:49:41]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2504433002/#ps40001
(title: "Gave test case an appropriate name.")

[commit-bot: I haz the power, 2016-11-15 18:50:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 18:57:38]

Description was changed from

==========
[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Previously each UI component that relied on this would have its separate checks
to see if PROXY_TABS was enabled or not, and only display the tabs data from the
OpenTabsUIDelegate if it was. As more UI was created that relied on foreign tabs
data, we saw the mistake of not making this check occur multiple times.

This change will result in a null OpenTabsUIDelegate being provided when proxy
tabs is disabled, and it will be impossible to make the mentioned mistake.

Going forward, there are a handful of places with logic that checks and/or
passes around if proxy tabs is enabled or not. As a follow up to this CL, we
should go through and remove/simplify all that logic as foreign tabs data will
no longer be accessible when proxy tabs becomes disabled.


BUG=662601
==========

to

==========
[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Previously each UI component that relied on this would have its separate checks
to see if PROXY_TABS was enabled or not, and only display the tabs data from the
OpenTabsUIDelegate if it was. As more UI was created that relied on foreign tabs
data, we saw the mistake of not making this check occur multiple times.

This change will result in a null OpenTabsUIDelegate being provided when proxy
tabs is disabled, and it will be impossible to make the mentioned mistake.

Going forward, there are a handful of places with logic that checks and/or
passes around if proxy tabs is enabled or not. As a follow up to this CL, we
should go through and remove/simplify all that logic as foreign tabs data will
no longer be accessible when proxy tabs becomes disabled.


BUG=662601
==========

[commit-bot: I haz the power, 2016-11-15 18:57:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-15 19:05:57]

Description was changed from

==========
[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Previously each UI component that relied on this would have its separate checks
to see if PROXY_TABS was enabled or not, and only display the tabs data from the
OpenTabsUIDelegate if it was. As more UI was created that relied on foreign tabs
data, we saw the mistake of not making this check occur multiple times.

This change will result in a null OpenTabsUIDelegate being provided when proxy
tabs is disabled, and it will be impossible to make the mentioned mistake.

Going forward, there are a handful of places with logic that checks and/or
passes around if proxy tabs is enabled or not. As a follow up to this CL, we
should go through and remove/simplify all that logic as foreign tabs data will
no longer be accessible when proxy tabs becomes disabled.


BUG=662601
==========

to

==========
[Sync] Return nullptr for OpenTabsUIDelegate when PROXY_TABS is disabled.

Previously each UI component that relied on this would have its separate checks
to see if PROXY_TABS was enabled or not, and only display the tabs data from the
OpenTabsUIDelegate if it was. As more UI was created that relied on foreign tabs
data, we saw the mistake of not making this check occur multiple times.

This change will result in a null OpenTabsUIDelegate being provided when proxy
tabs is disabled, and it will be impossible to make the mentioned mistake.

Going forward, there are a handful of places with logic that checks and/or
passes around if proxy tabs is enabled or not. As a follow up to this CL, we
should go through and remove/simplify all that logic as foreign tabs data will
no longer be accessible when proxy tabs becomes disabled.

BUG=662601

Committed: https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f
Cr-Commit-Position: refs/heads/master@{#432227}
==========

[commit-bot: I haz the power, 2016-11-15 19:05:58]

Patchset 3 (id:??) landed as
https://crrev.com/a816bfc268006458526fb07e84ac1e03cd1ac03f
Cr-Commit-Position: refs/heads/master@{#432227}