Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250443002: Remove NOTIFICATION_EXTENSION_LOADED_DEPRECATED from MenuManager. (Closed)

Created:
6 years, 8 months ago by limasdf
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove NOTIFICATION_EXTENSION_LOADED_DEPRECATED from MenuManager. R=kalman@chromium.org BUG=354046 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266173

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -52 lines) Patch
M chrome/browser/extensions/menu_manager.h View 5 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 3 chunks +31 lines, -41 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
limasdf
when you have time.
6 years, 8 months ago (2014-04-24 15:57:06 UTC) #1
not at google - send to devlin
lgtm
6 years, 8 months ago (2014-04-24 16:11:08 UTC) #2
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-24 16:11:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/250443002/80001
6 years, 8 months ago (2014-04-24 16:11:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:45:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 16:45:53 UTC) #6
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-24 16:48:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/250443002/80001
6 years, 8 months ago (2014-04-24 16:51:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 17:10:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 17:10:25 UTC) #10
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-24 18:34:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/250443002/80001
6 years, 8 months ago (2014-04-24 21:13:33 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:51:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 22:51:14 UTC) #14
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-25 01:16:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/250443002/80001
6 years, 8 months ago (2014-04-25 01:33:38 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 09:25:57 UTC) #17
Message was sent while issue was closed. 
Change committed as 266173

Powered by Google App Engine
This is Rietveld 408576698