Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3601)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java

Issue 2504413002: [NTP Client] Cleanup ContextMenuManager (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
index 2990625effbd17f382e5c2845164f58448a31232..301d086716fceabb157361257e6e4c264209f701 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
@@ -10,13 +10,10 @@
import android.view.View.OnClickListener;
import android.view.View.OnCreateContextMenuListener;
+import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.ui.mojom.WindowOpenDisposition;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.Set;
-
/**
* Displays the title, thumbnail, and favicon of a most visited page. The item can be clicked, or
* long-pressed to trigger a context menu with options to "open in new tab", "open in incognito
@@ -171,12 +168,8 @@ public String getUrl() {
}
@Override
- public Set<Integer> getSupportedMenuItems() {
- return new HashSet<>(Arrays.asList(ContextMenuManager.ID_OPEN_IN_NEW_WINDOW,
- ContextMenuManager.ID_OPEN_IN_NEW_TAB,
- ContextMenuManager.ID_OPEN_IN_INCOGNITO_TAB,
- ContextMenuManager.ID_REMOVE,
- ContextMenuManager.ID_SAVE_FOR_OFFLINE));
+ public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
+ return true;
}
});
}

Powered by Google App Engine
This is Rietveld 408576698