[stubs] KeyedStoreGeneric: inline dictionary property stores

src/builtins/builtins-array.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 #include "src/contexts.h"
 #include "src/elements.h"
@@ skipping 2548 matching lines @@
   assembler.Bind(&allocate_entry_if_needed);
   {
     assembler.GotoIf(
         assembler.Int32GreaterThan(
             instance_type,
             assembler.Int32Constant(LAST_ARRAY_KEY_VALUE_ITERATOR_TYPE)),
         &allocate_iterator_result);
 
     Node* elements =
         assembler.AllocateFixedArray(FAST_ELEMENTS, assembler.Int32Constant(2));
-    assembler.StoreFixedArrayElement(elements, assembler.Int32Constant(0),
-                                     index, SKIP_WRITE_BARRIER);
-    assembler.StoreFixedArrayElement(elements, assembler.Int32Constant(1),
-                                     var_value.value(), SKIP_WRITE_BARRIER);
+    assembler.StoreFixedArrayElement(elements, 0, index, SKIP_WRITE_BARRIER);

[Jakob Kummerow, 2016/11/21 17:02:58]

Drive-by cleanup.

+    assembler.StoreFixedArrayElement(elements, 1, var_value.value(),
+                                     SKIP_WRITE_BARRIER);
 
     Node* entry = assembler.Allocate(JSArray::kSize);
     Node* map =
         assembler.LoadContextElement(assembler.LoadNativeContext(context),
                                      Context::JS_ARRAY_FAST_ELEMENTS_MAP_INDEX);
 
     assembler.StoreMapNoWriteBarrier(entry, map);
     assembler.StoreObjectFieldRoot(entry, JSArray::kPropertiesOffset,
                                    Heap::kEmptyFixedArrayRootIndex);
     assembler.StoreObjectFieldNoWriteBarrier(entry, JSArray::kElementsOffset,
@@ skipping 30 matching lines @@
         Runtime::kThrowIncompatibleMethodReceiver, context,
         assembler.HeapConstant(assembler.factory()->NewStringFromAsciiChecked(
             "Array Iterator.prototype.next", TENURED)),
         iterator);
     assembler.Return(result);
   }
 }
 
 }  // namespace internal
 }  // namespace v8