Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: net/tools/quic/quic_in_memory_cache_test.cc

Issue 2504403003: Deprecates FLAGS_spdy_forbid_connection_response_header. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_in_memory_cache_test.cc
diff --git a/net/tools/quic/quic_in_memory_cache_test.cc b/net/tools/quic/quic_in_memory_cache_test.cc
index 249f6618f98abd91e5d71c1518512881273adad8..d26f533c55b823f68915ae464c2a17f2233647b2 100644
--- a/net/tools/quic/quic_in_memory_cache_test.cc
+++ b/net/tools/quic/quic_in_memory_cache_test.cc
@@ -110,7 +110,8 @@ TEST_F(QuicInMemoryCacheTest, ReadsCacheDir) {
ASSERT_TRUE(response);
ASSERT_TRUE(ContainsKey(response->headers(), ":status"));
EXPECT_EQ("200", response->headers().find(":status")->second);
- ASSERT_FALSE(ContainsKey(response->headers(), "connection"));
+ // Connection headers are not valid in HTTP/2.
+ EXPECT_FALSE(ContainsKey(response->headers(), "connection"));
EXPECT_LT(0U, response->body().length());
}
@@ -140,7 +141,8 @@ TEST_F(QuicInMemoryCacheTest, UsesOriginalUrl) {
ASSERT_TRUE(response);
ASSERT_TRUE(ContainsKey(response->headers(), ":status"));
EXPECT_EQ("200", response->headers().find(":status")->second);
- ASSERT_FALSE(ContainsKey(response->headers(), "connection"));
+ // Connection headers are not valid in HTTP/2.
+ EXPECT_FALSE(ContainsKey(response->headers(), "connection"));
EXPECT_LT(0U, response->body().length());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698