Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 25044003: Generate toCSSFooValue for CSS*GradientValues (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate toCSSFooValue for CSS*GradientValues As a step to use toCSSFooValue(), this cl generates toCSSGradientValue, toCSSLinearGradientValue and toCSSRadialGradientValue. To generate them, isLinearGradient(), isRadialGradient() need to have *Value* as a postfix. To be consistent with other isFooValue(), they're moved from CSSGradientValue to CSSValue. Generate toCSSFooValue() for CSSGradiendValue, CSSLinearGradientValue and CSSRadialGradientValue BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158596

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M Source/core/css/CSSGradientValue.h View 4 chunks +5 lines, -3 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 6 chunks +13 lines, -15 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-09-30 11:00:54 UTC) #1
tkent
https://chromiumcodereview.appspot.com/25044003/diff/1/Source/core/css/CSSGradientValue.cpp File Source/core/css/CSSGradientValue.cpp (right): https://chromiumcodereview.appspot.com/25044003/diff/1/Source/core/css/CSSGradientValue.cpp#newcode67 Source/core/css/CSSGradientValue.cpp:67: ASSERT(isRadialGradientValue()); This assertion is redundant.
7 years, 2 months ago (2013-09-30 23:54:37 UTC) #2
gyuyoung-inactive
https://chromiumcodereview.appspot.com/25044003/diff/1/Source/core/css/CSSGradientValue.cpp File Source/core/css/CSSGradientValue.cpp (right): https://chromiumcodereview.appspot.com/25044003/diff/1/Source/core/css/CSSGradientValue.cpp#newcode67 Source/core/css/CSSGradientValue.cpp:67: ASSERT(isRadialGradientValue()); On 2013/09/30 23:54:37, tkent wrote: > This assertion ...
7 years, 2 months ago (2013-10-01 02:27:42 UTC) #3
tkent
lgtm
7 years, 2 months ago (2013-10-01 02:35:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25044003/6001
7 years, 2 months ago (2013-10-01 02:35:08 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 05:45:20 UTC) #6
Message was sent while issue was closed.
Change committed as 158596

Powered by Google App Engine
This is Rietveld 408576698