Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: build/nocompile.gni

Issue 2504383002: Enable no-compile tests on non-windows and non-ios clang (Closed)
Patch Set: no ios Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/nocompile.gni
diff --git a/build/nocompile.gni b/build/nocompile.gni
index 1b292d79d19f8f226c7b9dea68ff569217652290..89335f5141c6905a69887f32344a45dccb9f91a0 100644
--- a/build/nocompile.gni
+++ b/build/nocompile.gni
@@ -58,8 +58,8 @@
import("//testing/test.gni")
declare_args() {
- # TODO(crbug.com/105388): Disabled until http://crbug.com/105388 is resolved.
- enable_nocompile_tests = false
+ # TODO(crbug.com/105388): make sure no-compile test is not flaky.
+ enable_nocompile_tests = !is_win && !is_ios && is_clang
}
if (enable_nocompile_tests) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698