Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 2504373002: Revert of Update references to linux_precise_blink_rel in src. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update references to linux_precise_blink_rel in src. (patchset #1 id:1 of https://codereview.chromium.org/2470243002/ ) Reason for revert: Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after http://crbug.com/665917 is fixed. Original issue's description: > Update references to linux_precise_blink_rel in src. > > Reason: We're planning to drop support for Linux Precise for layout tests. > > BUG=660580 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/ab87a374dd800813751d405a6fdf3a4c4b3066f7 > Cr-Commit-Position: refs/heads/master@{#430673} TBR=dpranke@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660580 Committed: https://crrev.com/745af0be287c0ef9e2af4694e80760931574945c Cr-Commit-Position: refs/heads/master@{#432545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M docs/updating_clang.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qyearsley
Created Revert of Update references to linux_precise_blink_rel in src.
4 years, 1 month ago (2016-11-16 17:30:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504373002/1
4 years, 1 month ago (2016-11-16 17:30:58 UTC) #3
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-16 17:43:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 17:45:55 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/745af0be287c0ef9e2af4694e80760931574945c Cr-Commit-Position: refs/heads/master@{#432545}
4 years, 1 month ago (2016-11-16 18:19:55 UTC) #7
qyearsley
4 years, 1 month ago (2016-11-17 17:48:45 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2509333002/ by qyearsley@chromium.org.

The reason for reverting is: linux_trusty_blink_rel is now working, with more
capacity.

Powered by Google App Engine
This is Rietveld 408576698