Issue 2504343002: GN: Removes libdart_nosnapshot_precompiled_runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2504343002: GN: Removes libdart_nosnapshot_precompiled_runtime (Closed)

Created:
4 years, 1 month ago by zra

Modified:
4 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

GN: Removes libdart_nosnapshot_precompiled_runtime It doesn't make sense, and building its build is broken. Committed: https://github.com/dart-lang/sdk/commit/8606013647803dbb499e1ee5967246548fcc7dd1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -37 lines)			Patch
	M	runtime/BUILD.gn	View		1 chunk	+0 lines, -11 lines	0 comments	Download
	M	runtime/vm/BUILD.gn	View		2 chunks	+0 lines, -26 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

Committed patchset #1 (id:1) manually as 8606013647803dbb499e1ee5967246548fcc7dd1 (presubmit successful).

4 years, 1 month ago (2016-11-16 16:57:22 UTC) #4

Message was sent while issue was closed.

LGTM

thanks