Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issue 2504313002: Fix some issues after introducing NamedType. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
Reviewers:
ahe
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some issues after introducing NamedType. Some code in type_checker.dart had not been updated and there was an unused method left in type_algebra.dart. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/kernel/commit/e6e61f5d3cc351b50e82cc7305bd7b485e512ee5

Patch Set 1 #

Patch Set 2 : Update testcase to cover the missing case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M lib/type_algebra.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M lib/type_checker.dart View 1 chunk +13 lines, -5 lines 0 comments Download
M testcases/input/named_parameters.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M testcases/spec-mode/named_parameters.baseline.txt View 1 2 chunks +5 lines, -2 lines 0 comments Download
M testcases/strong-mode/named_parameters.baseline.txt View 1 2 chunks +5 lines, -2 lines 0 comments Download
M testcases/type-propagation/named_parameters.baseline.txt View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
asgerf
4 years, 1 month ago (2016-11-16 15:46:17 UTC) #3
ahe
lgtm Do you have a test?
4 years, 1 month ago (2016-11-16 15:52:29 UTC) #4
asgerf
Updated the test to cover the code that was broken.
4 years, 1 month ago (2016-11-16 16:04:29 UTC) #5
asgerf
4 years, 1 month ago (2016-11-16 16:09:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e6e61f5d3cc351b50e82cc7305bd7b485e512ee5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698