Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(912)

Issue 2504263004: [crankshaft] No need to rely on the @@hasInstance protector. (Closed)

Created:
1 year, 3 months ago by Benedikt Meurer
Modified:
1 year, 3 months ago
Reviewers:
Franzi, Yang
CC:
v8-reviews_googlegroups.com, ofrobots
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] No need to rely on the @@hasInstance protector. In Crankshaft we can actually do an abstract interpretation of the @@hasInstance lookup when optimizing instanceof and then use the normal machinery to protect the result instead of relying on the global @@hasInstance protector cell for optimizations. This recovers the 100x performance drop in Node.js v7 reported in https://github.com/nodejs/node/issues/9634. This patch should be easily back-mergable to Node.js v7. BUG=v8:5640 R=yangguo@chromium.org,franzih@chromium.org Committed: https://crrev.com/08377af957b1602396ebf3e11ae000f15ed09333 Cr-Commit-Position: refs/heads/master@{#41059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +31 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
1 year, 3 months ago (2016-11-17 06:02:25 UTC) #1
Benedikt Meurer
Yang: PTAL Franziska: FYI
1 year, 3 months ago (2016-11-17 06:03:26 UTC) #4
Yang
On 2016/11/17 06:02:25, Benedikt Meurer wrote: lgtm.
1 year, 3 months ago (2016-11-17 06:04:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504263004/1
1 year, 3 months ago (2016-11-17 06:05:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 3 months ago (2016-11-17 06:39:37 UTC) #11
commit-bot: I haz the power
1 year, 3 months ago (2016-11-17 22:37:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08377af957b1602396ebf3e11ae000f15ed09333
Cr-Commit-Position: refs/heads/master@{#41059}

Powered by Google App Engine
This is Rietveld 408576698