Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: src/compiler.cc

Issue 2504223002: [fullcodegen] Remove deprecated generator implementation. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler.h" 5 #include "src/compiler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory> 8 #include <memory>
9 9
10 #include "src/asmjs/asm-js.h" 10 #include "src/asmjs/asm-js.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 // 3. Explicitly enabled by the command-line filter. 320 // 3. Explicitly enabled by the command-line filter.
321 bool passes_turbo_filter = shared->PassesFilter(FLAG_turbo_filter); 321 bool passes_turbo_filter = shared->PassesFilter(FLAG_turbo_filter);
322 322
323 return is_turbofanable_asm || is_unsupported_by_crankshaft_but_turbofanable || 323 return is_turbofanable_asm || is_unsupported_by_crankshaft_but_turbofanable ||
324 passes_turbo_filter; 324 passes_turbo_filter;
325 } 325 }
326 326
327 bool ShouldUseIgnition(CompilationInfo* info) { 327 bool ShouldUseIgnition(CompilationInfo* info) {
328 DCHECK(info->has_shared_info()); 328 DCHECK(info->has_shared_info());
329 329
330 // Resumable functions are not supported by {FullCodeGenerator}, suspended
331 // activations stored as {JSGeneratorObject} on the heap always assume the
332 // underlying code to be based on the bytecode array.
333 // TODO(mstarzinger): Once we want to deprecate even more support from the
334 // {FullCodeGenerator}, we will compute an appropriate bit in {AstNumbering}
335 // and turn this predicate into a DCHECK instead.
336 if (IsResumableFunction(info->shared_info()->kind())) {
337 return true;
338 }
339
330 // Skip Ignition for asm.js functions. 340 // Skip Ignition for asm.js functions.
331 if (info->shared_info()->asm_function()) { 341 if (info->shared_info()->asm_function()) {
332 return false; 342 return false;
333 } 343 }
334 344
335 // When requesting debug code as a replacement for existing code, we provide 345 // When requesting debug code as a replacement for existing code, we provide
336 // the same kind as the existing code (to prevent implicit tier-change). 346 // the same kind as the existing code (to prevent implicit tier-change).
337 if (info->is_debug() && info->shared_info()->is_compiled()) { 347 if (info->is_debug() && info->shared_info()->is_compiled()) {
338 return !info->shared_info()->HasBaselineCode(); 348 return !info->shared_info()->HasBaselineCode();
339 } 349 }
(...skipping 1381 matching lines...) Expand 10 before | Expand all | Expand 10 after
1721 DCHECK(shared->is_compiled()); 1731 DCHECK(shared->is_compiled());
1722 function->set_literals(cached.literals); 1732 function->set_literals(cached.literals);
1723 } else if (shared->is_compiled()) { 1733 } else if (shared->is_compiled()) {
1724 // TODO(mvstanton): pass pretenure flag to EnsureLiterals. 1734 // TODO(mvstanton): pass pretenure flag to EnsureLiterals.
1725 JSFunction::EnsureLiterals(function); 1735 JSFunction::EnsureLiterals(function);
1726 } 1736 }
1727 } 1737 }
1728 1738
1729 } // namespace internal 1739 } // namespace internal
1730 } // namespace v8 1740 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698