Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2504193005: Revert of Mojo EDK: Speculatively disable peer connection tests on Android (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo EDK: Speculatively disable peer connection tests on Android (patchset #1 id:1 of https://codereview.chromium.org/2505393003/ ) Reason for revert: Didn't fix the problem. Original issue's description: > Mojo EDK: Speculatively disable peer connection tests on Android > > Lots of flake appeared in the mojo_system_unittests suite on > Android bots after these tests were added. > > This speculatively disables those tests on Android, where the > feature isn't used in production anyway. > > BUG=666356 > TBR=sammc@chromium.org > > Committed: https://crrev.com/3bd8a572a0ab8ec0dd9df7195d4212ed86d1f6ae > Cr-Commit-Position: refs/heads/master@{#432925} TBR=sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666356 Committed: https://crrev.com/b202f5d598b5cb4e03ca662fe439d2f4363d82eb Cr-Commit-Position: refs/heads/master@{#433202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 3 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Mojo EDK: Speculatively disable peer connection tests on Android
4 years, 1 month ago (2016-11-18 15:34:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504193005/1
4 years, 1 month ago (2016-11-18 15:35:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 15:36:04 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 15:38:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b202f5d598b5cb4e03ca662fe439d2f4363d82eb
Cr-Commit-Position: refs/heads/master@{#433202}

Powered by Google App Engine
This is Rietveld 408576698