Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2504193004: Send CacheCleanUpRequest instead of a List. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Paul Berry, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Make the request class public to work around the problem. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart View 1 3 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
scheglov
4 years, 1 month ago (2016-11-17 18:31:17 UTC) #1
scheglov
PTAL I found a workaround, with the second diff. So, I'd like to land this ...
4 years, 1 month ago (2016-11-17 19:01:45 UTC) #2
Paul Berry
lgtm, but please change the CL description before landing (it's still called "With this CL ...
4 years, 1 month ago (2016-11-17 19:03:32 UTC) #3
scheglov
4 years, 1 month ago (2016-11-17 19:16:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3215a1b2becaedf938d8e056ab43655ef95a1684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698