Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2504193002: [heap] Simplify adjusting of live bytes. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Simplify adjusting of live bytes. We never increment live bytes concurrent to the sweeper. BUG= Committed: https://crrev.com/d3f2213b61ea33473f0fa0bc49bc2a1209c24d9b Cr-Commit-Position: refs/heads/master@{#41097}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -91 lines) Patch
M src/elements.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/heap/heap.h View 1 2 chunks +1 line, -8 lines 0 comments Download
M src/heap/heap.cc View 1 5 chunks +5 lines, -18 lines 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/heap/mark-compact-inl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces-inl.h View 1 3 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/layout-descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 9 chunks +9 lines, -14 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/heap/heap-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
ulan
ptal
4 years, 1 month ago (2016-11-16 12:36:17 UTC) #2
Michael Lippautz
LGTM +Hannes I checked how the counters are used and from my understand everything is ...
4 years, 1 month ago (2016-11-16 13:55:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504193002/1
4 years, 1 month ago (2016-11-17 09:25:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/28083) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 09:26:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504193002/20001
4 years, 1 month ago (2016-11-17 15:13:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/12344) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 15:34:08 UTC) #13
Hannes Payer (out of office)
LGTM
4 years, 1 month ago (2016-11-18 07:15:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504193002/40001
4 years, 1 month ago (2016-11-18 10:33:53 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-18 11:11:37 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 11:12:07 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d3f2213b61ea33473f0fa0bc49bc2a1209c24d9b
Cr-Commit-Position: refs/heads/master@{#41097}

Powered by Google App Engine
This is Rietveld 408576698