Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: chrome/common/variations/child_process_field_trial_syncer.cc

Issue 2504163005: Fix getting initially active trials with shared memory. (Closed)
Patch Set: Fix single process mode which is used by PhishingClassifierTest on Windows. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/variations/child_process_field_trial_syncer.h" 5 #include "chrome/common/variations/child_process_field_trial_syncer.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/base_switches.h" 10 #include "base/base_switches.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "components/variations/variations_util.h" 12 #include "components/variations/variations_util.h"
13 #include "content/public/common/content_switches.h"
13 14
14 namespace chrome_variations { 15 namespace chrome_variations {
15 16
16 ChildProcessFieldTrialSyncer::ChildProcessFieldTrialSyncer( 17 ChildProcessFieldTrialSyncer::ChildProcessFieldTrialSyncer(
17 base::FieldTrialList::Observer* observer) 18 base::FieldTrialList::Observer* observer)
18 : observer_(observer) {} 19 : observer_(observer) {}
19 20
20 ChildProcessFieldTrialSyncer::~ChildProcessFieldTrialSyncer() {} 21 ChildProcessFieldTrialSyncer::~ChildProcessFieldTrialSyncer() {}
21 22
22 void ChildProcessFieldTrialSyncer::InitFieldTrialObserving( 23 void ChildProcessFieldTrialSyncer::InitFieldTrialObserving(
23 const base::CommandLine& command_line) { 24 const base::CommandLine& command_line) {
25 // In single-process mode, there is no need to synchronize trials to the
26 // browser process (because it's the same process), so this class is a no-op.
27 if (command_line.HasSwitch(switches::kSingleProcess))
28 return;
29
24 // Set up initial set of crash dump data for field trials in this process. 30 // Set up initial set of crash dump data for field trials in this process.
25 variations::SetVariationListCrashKeys(); 31 variations::SetVariationListCrashKeys();
26 32
27 // Listen for field trial activations to report them to the browser. 33 // Listen for field trial activations to report them to the browser.
28 base::FieldTrialList::AddObserver(observer_); 34 base::FieldTrialList::AddObserver(observer_);
29 35
30 // Some field trials may have been activated before this point. Notify the 36 // Some field trials may have been activated before this point. Notify the
31 // browser of these activations now. To detect these, take the set difference 37 // browser of these activations now. To detect these, take the set difference
32 // of currently active trials with the initially active trials. 38 // of currently active trials with the initially active trials.
33 base::FieldTrial::ActiveGroups initially_active_trials; 39 base::FieldTrial::ActiveGroups initially_active_trials;
34 base::FieldTrialList::GetActiveFieldTrialGroupsFromString( 40 base::FieldTrialList::GetInitiallyActiveFieldTrials(command_line,
35 command_line.GetSwitchValueASCII(switches::kForceFieldTrials), 41 &initially_active_trials);
36 &initially_active_trials);
37 std::set<std::string> initially_active_trials_set; 42 std::set<std::string> initially_active_trials_set;
38 for (const auto& entry : initially_active_trials) { 43 for (const auto& entry : initially_active_trials) {
39 initially_active_trials_set.insert(std::move(entry.trial_name)); 44 initially_active_trials_set.insert(std::move(entry.trial_name));
40 } 45 }
41 46
42 base::FieldTrial::ActiveGroups current_active_trials; 47 base::FieldTrial::ActiveGroups current_active_trials;
43 base::FieldTrialList::GetActiveFieldTrialGroups(&current_active_trials); 48 base::FieldTrialList::GetActiveFieldTrialGroups(&current_active_trials);
44 for (const auto& trial : current_active_trials) { 49 for (const auto& trial : current_active_trials) {
45 if (!base::ContainsKey(initially_active_trials_set, trial.trial_name)) 50 if (!base::ContainsKey(initially_active_trials_set, trial.trial_name))
46 observer_->OnFieldTrialGroupFinalized(trial.trial_name, trial.group_name); 51 observer_->OnFieldTrialGroupFinalized(trial.trial_name, trial.group_name);
47 } 52 }
48 } 53 }
49 54
50 void ChildProcessFieldTrialSyncer::OnSetFieldTrialGroup( 55 void ChildProcessFieldTrialSyncer::OnSetFieldTrialGroup(
51 const std::string& trial_name, 56 const std::string& trial_name,
52 const std::string& group_name) { 57 const std::string& group_name) {
53 base::FieldTrial* trial = 58 base::FieldTrial* trial =
54 base::FieldTrialList::CreateFieldTrial(trial_name, group_name); 59 base::FieldTrialList::CreateFieldTrial(trial_name, group_name);
55 // Ensure the trial is marked as "used" by calling group() on it if it is 60 // Ensure the trial is marked as "used" by calling group() on it if it is
56 // marked as activated. 61 // marked as activated.
57 trial->group(); 62 trial->group();
58 variations::SetVariationListCrashKeys(); 63 variations::SetVariationListCrashKeys();
59 } 64 }
60 65
61 } // namespace chrome_variations 66 } // namespace chrome_variations
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698