Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2504163002: [turbofan] Don't check for neutered array buffers eagerly. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
ulan, Jarin
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't check for neutered array buffers eagerly. We don't need to check for neutered array buffers unless at least one JSArrayBuffer has been neutered (i.e. detached in TC39 speak). For this we introduce a protector cell that get's invalidated on first call to the JSArrayBuffer::Neuter() method. R=jarin@chromium.org,ulan@chromium.org BUG=v8:5267 Committed: https://crrev.com/36e3af325aad839bef36ba3670cb09bb8cf0dc86 Cr-Commit-Position: refs/heads/master@{#41021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+882 lines, -37 lines) Patch
M src/compiler/js-builtin-reducer.cc View 3 chunks +58 lines, -31 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +14 lines, -6 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/es6/typedarray-neutered.js View 1 chunk +781 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-16 10:07:46 UTC) #1
Jarin
I am not too wild about introducing another non-local performance cliff, but if you think ...
4 years, 1 month ago (2016-11-16 10:13:43 UTC) #4
ulan
heap lgtm
4 years, 1 month ago (2016-11-16 10:22:40 UTC) #5
Benedikt Meurer
Well, we're playing this benchmark game unfortunately, and the cliff is not too bad (this ...
4 years, 1 month ago (2016-11-16 10:26:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504163002/1
4 years, 1 month ago (2016-11-16 10:26:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 10:35:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:35:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36e3af325aad839bef36ba3670cb09bb8cf0dc86
Cr-Commit-Position: refs/heads/master@{#41021}

Powered by Google App Engine
This is Rietveld 408576698