Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: test/mjsunit/strong-rooted-literals.js

Issue 2504153002: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: REBASE. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/unittests/compiler/js-create-lowering-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/strong-rooted-literals.js
diff --git a/test/mjsunit/strong-rooted-literals.js b/test/mjsunit/strong-rooted-literals.js
new file mode 100644
index 0000000000000000000000000000000000000000..87ba966c1f0c0b6b2cbe2346eac1a278c4d83b86
--- /dev/null
+++ b/test/mjsunit/strong-rooted-literals.js
@@ -0,0 +1,40 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax --expose-gc
+
+// Make sure literals are strongly rooted and safe from weak-code deopts.
+(function() {
+ function foo() {
+ var a = { y: 0 };
+ a.y = 1;
+ return a;
+ }
+
+ foo();
+ foo();
+ %OptimizeFunctionOnNextCall(foo);
+ foo();
+ gc();
+ assertOptimized(foo);
+})();
+
+
+(function() {
+ function hot(o) {
+ return o.x + o.y;
+ }
+ function mapPlus(a, y) {
+ return a.map(x => hot({x, y}));
+ }
+
+ var a = [1, 2, 3];
+ print(mapPlus(a, 1));
+ print(mapPlus(a, 2));
+ %OptimizeFunctionOnNextCall(hot);
+ print(mapPlus(a, 3));
+ gc(); // BOOOM!
+ assertOptimized(hot);
+ print(mapPlus(a, 4));
+})();
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/unittests/compiler/js-create-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698