Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/objects-printer.cc

Issue 2504153002: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: REBASE. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index cf4c5d88755cecf6647185fa2cc307110122da84..ebcf1e21821f847d14d9565e06babe4066517032 100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -727,10 +727,15 @@ void TypeFeedbackMetadata::TypeFeedbackMetadataPrint(
os << "\n - slot_count: " << slot_count();
TypeFeedbackMetadataIterator iter(this);
+ int parameter_index = 0;
while (iter.HasNext()) {
FeedbackVectorSlot slot = iter.Next();
FeedbackVectorSlotKind kind = iter.kind();
os << "\n Slot " << slot << " " << kind;
+ if (TypeFeedbackMetadata::SlotRequiresParameter(kind)) {
+ int parameter_value = this->GetParameter(parameter_index++);
+ os << " [" << parameter_value << "]";
+ }
}
os << "\n";
}
@@ -751,6 +756,7 @@ void TypeFeedbackVector::TypeFeedbackVectorPrint(std::ostream& os) { // NOLINT
return;
}
+ int parameter_index = 0;
TypeFeedbackMetadataIterator iter(metadata());
while (iter.HasNext()) {
FeedbackVectorSlot slot = iter.Next();
@@ -799,6 +805,12 @@ void TypeFeedbackVector::TypeFeedbackVectorPrint(std::ostream& os) { // NOLINT
os << Code::ICState2String(nexus.StateFromFeedback());
break;
}
+ case FeedbackVectorSlotKind::CREATE_CLOSURE: {
+ // TODO(mvstanton): Integrate this into the iterator.
+ int parameter_value = metadata()->GetParameter(parameter_index++);
+ os << "[" << parameter_value << "]";
+ break;
+ }
case FeedbackVectorSlotKind::GENERAL:
break;
case FeedbackVectorSlotKind::INVALID:

Powered by Google App Engine
This is Rietveld 408576698