Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/compiler.cc

Issue 2504153002: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: REBASE. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 2d0cf06cbd0a8572b2192a2a284ac0d023652729..71d0dbb885d2524435f8e61f707ed935e9e4ad4e 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -482,14 +482,13 @@ MUST_USE_RESULT MaybeHandle<Code> GetCodeFromOptimizedCodeMap(
Handle<JSFunction> function, BailoutId osr_ast_id) {
Handle<SharedFunctionInfo> shared(function->shared());
DisallowHeapAllocation no_gc;
- CodeAndLiterals cached = shared->SearchOptimizedCodeMap(
+ Code* code = shared->SearchOptimizedCodeMap(
function->context()->native_context(), osr_ast_id);
- if (cached.code != nullptr) {
+ if (code != nullptr) {
// Caching of optimized code enabled and optimized code found.
- if (cached.literals != nullptr) function->set_literals(cached.literals);
- DCHECK(!cached.code->marked_for_deoptimization());
+ DCHECK(!code->marked_for_deoptimization());
DCHECK(function->shared()->is_compiled());
- return Handle<Code>(cached.code);
+ return Handle<Code>(code);
}
return MaybeHandle<Code>();
}
@@ -511,10 +510,9 @@ void InsertCodeIntoOptimizedCodeMap(CompilationInfo* info) {
// Cache optimized context-specific code.
Handle<JSFunction> function = info->closure();
Handle<SharedFunctionInfo> shared(function->shared());
- Handle<LiteralsArray> literals(function->literals());
Handle<Context> native_context(function->context()->native_context());
SharedFunctionInfo::AddToOptimizedCodeMap(shared, native_context, code,
- literals, info->osr_ast_id());
+ info->osr_ast_id());
}
bool Renumber(ParseInfo* parse_info) {
@@ -769,10 +767,8 @@ CompilationJob::Status FinalizeOptimizedCompilationJob(CompilationJob* job) {
} else if (job->FinalizeJob() == CompilationJob::SUCCEEDED) {
job->RecordOptimizedCompilationStats();
RecordFunctionCompilation(CodeEventListener::LAZY_COMPILE_TAG, info);
- if (shared
- ->SearchOptimizedCodeMap(info->context()->native_context(),
- info->osr_ast_id())
- .code == nullptr) {
+ if (shared->SearchOptimizedCodeMap(info->context()->native_context(),
+ info->osr_ast_id()) == nullptr) {
InsertCodeIntoOptimizedCodeMap(info);
}
if (FLAG_trace_opt) {
@@ -1708,19 +1704,16 @@ void Compiler::PostInstantiation(Handle<JSFunction> function,
function->MarkForOptimization();
}
- CodeAndLiterals cached = shared->SearchOptimizedCodeMap(
+ Code* code = shared->SearchOptimizedCodeMap(
function->context()->native_context(), BailoutId::None());
- if (cached.code != nullptr) {
+ if (code != nullptr) {
// Caching of optimized code enabled and optimized code found.
- DCHECK(!cached.code->marked_for_deoptimization());
+ DCHECK(!code->marked_for_deoptimization());
DCHECK(function->shared()->is_compiled());
- function->ReplaceCode(cached.code);
+ function->ReplaceCode(code);
}
- if (cached.literals != nullptr) {
- DCHECK(shared->is_compiled());
- function->set_literals(cached.literals);
- } else if (shared->is_compiled()) {
+ if (shared->is_compiled()) {
// TODO(mvstanton): pass pretenure flag to EnsureLiterals.
JSFunction::EnsureLiterals(function);
}

Powered by Google App Engine
This is Rietveld 408576698