Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/type-feedback-vector-inl.h

Issue 2504153002: [TypeFeedbackVector] Root literal arrays in function literals slots (Closed)
Patch Set: REBASE. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/type-feedback-vector.cc ('k') | src/x64/interface-descriptors-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_TYPE_FEEDBACK_VECTOR_INL_H_ 5 #ifndef V8_TYPE_FEEDBACK_VECTOR_INL_H_
6 #define V8_TYPE_FEEDBACK_VECTOR_INL_H_ 6 #define V8_TYPE_FEEDBACK_VECTOR_INL_H_
7 7
8 #include "src/globals.h" 8 #include "src/globals.h"
9 #include "src/type-feedback-vector.h" 9 #include "src/type-feedback-vector.h"
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 DCHECK(obj->IsTypeFeedbackVector()); 48 DCHECK(obj->IsTypeFeedbackVector());
49 return reinterpret_cast<TypeFeedbackVector*>(obj); 49 return reinterpret_cast<TypeFeedbackVector*>(obj);
50 } 50 }
51 51
52 52
53 int TypeFeedbackMetadata::GetSlotSize(FeedbackVectorSlotKind kind) { 53 int TypeFeedbackMetadata::GetSlotSize(FeedbackVectorSlotKind kind) {
54 DCHECK_NE(FeedbackVectorSlotKind::INVALID, kind); 54 DCHECK_NE(FeedbackVectorSlotKind::INVALID, kind);
55 DCHECK_NE(FeedbackVectorSlotKind::KINDS_NUMBER, kind); 55 DCHECK_NE(FeedbackVectorSlotKind::KINDS_NUMBER, kind);
56 if (kind == FeedbackVectorSlotKind::GENERAL || 56 if (kind == FeedbackVectorSlotKind::GENERAL ||
57 kind == FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC || 57 kind == FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC ||
58 kind == FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC) { 58 kind == FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC ||
59 kind == FeedbackVectorSlotKind::CREATE_CLOSURE) {
59 return 1; 60 return 1;
60 } 61 }
61 62
62 return 2; 63 return 2;
63 } 64 }
64 65
66 bool TypeFeedbackMetadata::SlotRequiresParameter(FeedbackVectorSlotKind kind) {
67 switch (kind) {
68 case FeedbackVectorSlotKind::CREATE_CLOSURE:
69 return true;
70
71 case FeedbackVectorSlotKind::CALL_IC:
72 case FeedbackVectorSlotKind::LOAD_IC:
73 case FeedbackVectorSlotKind::LOAD_GLOBAL_IC:
74 case FeedbackVectorSlotKind::KEYED_LOAD_IC:
75 case FeedbackVectorSlotKind::STORE_IC:
76 case FeedbackVectorSlotKind::KEYED_STORE_IC:
77 case FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC:
78 case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC:
79 case FeedbackVectorSlotKind::GENERAL:
80 case FeedbackVectorSlotKind::INVALID:
81 return false;
82
83 case FeedbackVectorSlotKind::KINDS_NUMBER:
84 break;
85 }
86 UNREACHABLE();
87 return false;
88 }
89
65 bool TypeFeedbackVector::is_empty() const { 90 bool TypeFeedbackVector::is_empty() const {
66 return length() == kReservedIndexCount; 91 return length() == kReservedIndexCount;
67 } 92 }
68 93
69 int TypeFeedbackVector::slot_count() const { 94 int TypeFeedbackVector::slot_count() const {
70 return length() - kReservedIndexCount; 95 return length() - kReservedIndexCount;
71 } 96 }
72 97
73 98
74 TypeFeedbackMetadata* TypeFeedbackVector::metadata() const { 99 TypeFeedbackMetadata* TypeFeedbackVector::metadata() const {
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 if (hint == BinaryOperationHint::kAny) { 214 if (hint == BinaryOperationHint::kAny) {
190 gen++; 215 gen++;
191 } else if (hint != BinaryOperationHint::kNone) { 216 } else if (hint != BinaryOperationHint::kNone) {
192 with++; 217 with++;
193 } 218 }
194 } 219 }
195 total++; 220 total++;
196 } 221 }
197 break; 222 break;
198 } 223 }
224 case FeedbackVectorSlotKind::CREATE_CLOSURE:
199 case FeedbackVectorSlotKind::GENERAL: 225 case FeedbackVectorSlotKind::GENERAL:
200 break; 226 break;
201 case FeedbackVectorSlotKind::INVALID: 227 case FeedbackVectorSlotKind::INVALID:
202 case FeedbackVectorSlotKind::KINDS_NUMBER: 228 case FeedbackVectorSlotKind::KINDS_NUMBER:
203 UNREACHABLE(); 229 UNREACHABLE();
204 break; 230 break;
205 } 231 }
206 } 232 }
207 233
208 *with_type_info = with; 234 *with_type_info = with;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 int index = vector()->GetIndex(slot()) + 1; 295 int index = vector()->GetIndex(slot()) + 1;
270 vector()->set(index, feedback_extra, mode); 296 vector()->set(index, feedback_extra, mode);
271 } 297 }
272 298
273 299
274 Isolate* FeedbackNexus::GetIsolate() const { return vector()->GetIsolate(); } 300 Isolate* FeedbackNexus::GetIsolate() const { return vector()->GetIsolate(); }
275 } // namespace internal 301 } // namespace internal
276 } // namespace v8 302 } // namespace v8
277 303
278 #endif // V8_TYPE_FEEDBACK_VECTOR_INL_H_ 304 #endif // V8_TYPE_FEEDBACK_VECTOR_INL_H_
OLDNEW
« no previous file with comments | « src/type-feedback-vector.cc ('k') | src/x64/interface-descriptors-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698